http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java
File user/src/com/google/gwt/storage/client/Storage.java (right):
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java
File user/src/com/google/gwt/storage/client/Storage.java (right):
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107
Allahbaksh,
This group (google-web-toolkit-contributors) is a little noisy and isn't
really used for general discussion. If you would like to discuss the
specifics of a review, you will probably get a better response if you use
the review site directly
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
File
user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
(right):
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Everything looks good, but there are some places where you can simplify
the Impl classes.
http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java
File user/src/com/google/gwt/storage/client/StorageImpl.java (right):
http://gwt-code-reviews.appspot.com/1374803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java
File user/src/com/google/gwt/storage/client/StorageImpl.java (right):
http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java#newcode193
This CL looks great. Cross off another one for HTML5 support.
http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
File
user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java
(right):
HI,
Sorry this post is different from the review. I have following
questions
1)I am not sure whether this can be used with IndexDB which is new
HTML5 specification.
2)How about using some third party library for HTML5 storage on non
HTML5 supported browser like FF3.0 etc
3)Why not include
15 matches
Mail list logo