[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java File user/src/com/google/gwt/storage/client/Storage.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java File user/src/com/google/gwt/storage/client/Storage.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107

Re: [gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-06 Thread Philip Rogers
Allahbaksh, This group (google-web-toolkit-contributors) is a little noisy and isn't really used for general discussion. If you would like to discuss the specifics of a review, you will probably get a better response if you use the review site directly

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-06 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-06 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-05 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java File user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java (right):

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-05 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-05 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-04 Thread jlabanca
LGTM Everything looks good, but there are some places where you can simplify the Impl classes. http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java File user/src/com/google/gwt/storage/client/StorageImpl.java (right):

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-04 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-04 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java File user/src/com/google/gwt/storage/client/StorageImpl.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/1/user/src/com/google/gwt/storage/client/StorageImpl.java#newcode193

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-04 Thread jlabanca
This CL looks great. Cross off another one for HTML5 support. http://gwt-code-reviews.appspot.com/1374803/diff/20/user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java File user/src/com/google/gwt/storage/client/StorageImplNonNativeEvents.java (right):

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-04 Thread Allahbaksh Asadullah
HI, Sorry this post is different from the review. I have following questions 1)I am not sure whether this can be used with IndexDB which is new HTML5 specification. 2)How about using some third party library for HTML5 storage on non HTML5 supported browser like FF3.0 etc 3)Why not include