LGTM with some nits

http://gwt-code-reviews.appspot.com/901801/diff/1/3
File user/src/com/google/gwt/user/client/ui/DirectionalTextHelper.java
(right):

http://gwt-code-reviews.appspot.com/901801/diff/1/3#newcode29
user/src/com/google/gwt/user/client/ui/DirectionalTextHelper.java:29:
public class DirectionalTextHelper implements HasDirectionEstimator {
We should make this class package protected so we can change the
implementation as needed.

http://gwt-code-reviews.appspot.com/901801/diff/1/4
File user/src/com/google/gwt/user/client/ui/Hyperlink.java (right):

http://gwt-code-reviews.appspot.com/901801/diff/1/4#newcode21
user/src/com/google/gwt/user/client/ui/Hyperlink.java:21:
extra space

http://gwt-code-reviews.appspot.com/901801/diff/1/4#newcode289
user/src/com/google/gwt/user/client/ui/Hyperlink.java:289:
extra newline (unless we were missing one at the end of the file)

http://gwt-code-reviews.appspot.com/901801/diff/1/5
File user/src/com/google/gwt/user/client/ui/Label.java (right):

http://gwt-code-reviews.appspot.com/901801/diff/1/5#newcode453
user/src/com/google/gwt/user/client/ui/Label.java:453:
extra newline

http://gwt-code-reviews.appspot.com/901801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to