[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-13 Thread skybrian
On 2012/09/13 09:57:02, manolo.carrasco wrote: RF fails in the case of @ProxyFor pointing to a domain-interface instead of a domain-implementation, could you consider to include the patch https://gwt-code-reviews.appspot.com/1764804/ as well in 2.5? I think that counts as a new feature

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-13 Thread Thomas Broyer
Well, if you ask me, it can wait the next release. There's a workaround in the meantime: don't rely on ValidationTool to generate the Deobfuscator.Builder, generate it yourself by other means. I wrote such a generator for a project, 'cause we had many @SkipInterfaceValidation methods (and much

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-13 Thread manuel . carrasco . m
We are using domain interfaces in a couple of projects and finally we decided to patch this file to avoid such amount of extra code. I thought this was a very small piece of code which IMHO fixes an important issue, and could be related with this commit, so that is the reason to suggest the

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-13 Thread t . broyer
On 2012/09/13 18:35:35, manolo.carrasco wrote: We are using domain interfaces in a couple of projects and finally we decided to patch this file to avoid such amount of extra code. I thought this was a very small piece of code which IMHO fixes an important issue, and could be related with

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-07 Thread skybrian
LGTM. Committing... https://gwt-code-reviews.appspot.com/1712803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-07 Thread skybrian
On 2012/09/07 19:57:58, skybrian wrote: LGTM. Committing... I'm getting 500 errors in MultipleFactoriesTest. java.lang.RuntimeException: The RequestFactory ValidationTool must be run for the com.google.web.bindery.requestfactory.shared.MultipleFactoriesTest.Factory1 RequestFactory type

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-07 Thread skybrian
Never mind, looks like a hard-coded list in our build file. https://gwt-code-reviews.appspot.com/1712803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-06 Thread t . broyer
https://gwt-code-reviews.appspot.com/1712803/diff/2001/user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java File user/src/com/google/web/bindery/requestfactory/vm/impl/Deobfuscator.java (right):

[gwt-contrib] Re: Issue 7381: 2 RequestFactory with 2 differents Proxy on the same domain class (issue1712803)

2012-09-06 Thread Brian Slesinsky
Thanks Thomas, that helps. (I think serverTypeToProxyTypes might be a better name.) I was curious about how often this code it gets run. It looks like it happens on every RPC call though this path: SimpleRequestProcessor.processInvocationMessages() - ResolverServiceLayer.updateDeobfuscator() -