[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread drfibonacci
Upgrade GAE version http://gwt-code-reviews.appspot.com/1829803/diff/4001/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1829803/diff/4001/samples/mobilewebapp/pom.xml#newcode21 samples/mobilewebapp/pom.xml:21:

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread rdayal
http://gwt-code-reviews.appspot.com/1829803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread t . broyer
I'm sorry I've only started to review the files (over the last few days) but I have a first question/comment about where this is going: There are many things that are not needed in the case of MobileWebApp as the host page is protected behind authentication. Because the user won't ever see this

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread Rajeev Dayal
Hey Thomas, Thanks for looking this over. I'll reply to the code-specific comments in Rietveld itself, but I thought I'd respond to your more pressing concerns first. On Fri, Sep 14, 2012 at 10:57 AM, t.bro...@gmail.com wrote: I'm sorry I've only started to review the files (over the last few

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread rdayal
http://gwt-code-reviews.appspot.com/1829803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-14 Thread rdayal
On 2012/09/14 18:53:22, rdayal wrote: I think this one is going to be pushed past GWT 2.5; that's ok though. http://gwt-code-reviews.appspot.com/1829803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-12 Thread rdayal
On 2012/09/12 22:50:12, rdayal wrote: Ping...I'd like to get this into 2.5. http://gwt-code-reviews.appspot.com/1829803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move GAE Auth functionality from Expenses over the MobileWebApp sample. (issue1829803)

2012-09-11 Thread rdayal
On 2012/09/11 20:36:11, rdayal wrote: Had to re-create this; my client was messed up. Original review was here: http://gwt-code-reviews.appspot.com/1806803/ Note that this review is built on the changes here: http://gwt-code-reviews.appspot.com/1828803/ (hence they are included)