[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread Scott Blum
Committed at r4302. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread Scott Blum
On Wed, Dec 10, 2008 at 6:51 PM, BobV <[EMAIL PROTECTED]> wrote: > dev/core/src/com/google/gwt/core/ext/linker/AbstractLinker.java > | 7170 +1 - 0 ! > > What's with the @SuppressWarnings tags? > logger is unused, UnableToComplete not actually thrown. > > dev/core/src/com/go

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread Scott Blum
On Wed, Dec 10, 2008 at 6:59 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > On Wed, Dec 10, 2008 at 3:51 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> John, this is the corresponding change to the Linux binary to support it. >> > > Changing the test for the number of arguments to gwtOnLoad will pr

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread John Tamplin
On Wed, Dec 10, 2008 at 3:51 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > John, this is the corresponding change to the Linux binary to support it. > Changing the test for the number of arguments to gwtOnLoad will prevent older hosted.html from working with no possibility of working supporting it

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread BobV
dev/core/src/com/google/gwt/core/ext/linker/AbstractLinker.java | 7170 +1 - 0 ! What's with the @SuppressWarnings tags? dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java | 20 13 +7 - 0 ! emitSelectionScript(): add a comment to explain l

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-10 Thread Scott Blum
John, this is the corresponding change to the Linux binary to support it. BTW: how do we build libstdc++5 compatible binaries these days? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-09 Thread Scott Blum
On Tue, Dec 9, 2008 at 9:48 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> We deal with this problem now by asserting that hosted mode will generally >> not overwrite web mode artifacts unless they are newer. For the specif

[gwt-contrib] Re: Need review for more 1.6 WAR changes

2008-12-09 Thread John Tamplin
On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > We deal with this problem now by asserting that hosted mode will generally > not overwrite web mode artifacts unless they are newer. For the specific > case of the selection script, we give the hosted mode generated selection