[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-11 Thread zundel
http://gwt-code-reviews.appspot.com/1359801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-11 Thread zundel
updated patch http://gwt-code-reviews.appspot.com/1359801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java (right): http://gwt-code-reviews.appspot.com/1359801/diff/1/3#newcode48 dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:48: if (declaringClass

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-11 Thread jbrosenberg
LGTM + nits http://gwt-code-reviews.appspot.com/1359801/diff/6002/7 File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java (right): http://gwt-code-reviews.appspot.com/1359801/diff/6002/7#newcode39 dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:39: * visible in

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-11 Thread zundel
http://gwt-code-reviews.appspot.com/1359801/diff/6002/7 File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java (right): http://gwt-code-reviews.appspot.com/1359801/diff/6002/7#newcode39 dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:39: * visible in the

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-11 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/1359801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)

2011-02-10 Thread zundel
Scott and I noticed that the MethodArgNamesLookup did not contain all the methods we thought it should. This could result in extra parsing time if the diet parse needs to be called to resolve method argument names. http://gwt-code-reviews.appspot.com/1359801/diff/1/4 File