Why did you remove classes/marker? Its needed by Eclipse or it throws
an error because it can't find the classes/ directory where it is
supposed to dump compiled files.
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Unintentional. I am OOO today, so I can't fix it till at least tonight. I
will be happy to review a CL.
On Fri, Sep 10, 2010 at 10:54 AM, jlaba...@google.com wrote:
Why did you remove classes/marker? Its needed by Eclipse or it throws
an error because it can't find the classes/ directory
LGTM
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class? clazz;
Could
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class? clazz;
On
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Please take a look now.
Smoke test pass. checkstyle passes
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/09/03 23:10:54, Nick Chalko wrote:
Disregard. this is not ready yet. test failing, and checkstyle errors.
I will resend when ready.
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
