Amit, can you review the attached patch for solution #1 as originally
outlined.
Do we have a short/long test breakdown for Emma (i.e. is what's there
long, and EmmaClassLoading test only short)? And do we actually want to
go with short/long emma, only, or more generally have a short/long
LGTM.
Yes, the short/long test breakdown should be EmmaClassLoadingTest and
others. It is okay if we do this short/long partitioning later, when we do
it across all tests.
Amit
On Fri, Apr 24, 2009 at 10:13 AM, Freeland Abbott fabb...@google.comwrote:
Amit, can you review the attached patch
Well, that will run emma tests for everyone everywhere who does ant
test...
Does it require anything in particular to work, which people might not have
installed? And is the time significant?
We can easily enough tweak the continuous builder configuration to
explicitly run the emma tests, if
It just requires emma.jar which is pulled in from the tools dir. The time is
basically the same as running hosted mode user tests.
Amit
On Thu, Apr 23, 2009 at 10:41 AM, Freeland Abbott fabb...@google.comwrote:
Well, that will run emma tests for everyone everywhere who does ant
test...
Does
But now we're running them twice.
I'll give you the LGTM as testing is good, but I'm a bit worried for the
time penalty. But if it's a problem, we can fall back to the other approach
when it's clear it's a problem.
On Thu, Apr 23, 2009 at 1:50 PM, Amit Manjhi amitman...@google.com wrote:
It
Makes sense. Thanks. Commited as r5275
On Thu, Apr 23, 2009 at 10:52 AM, Freeland Abbott fabb...@google.comwrote:
But now we're running them twice.
I'll give you the LGTM as testing is good, but I'm a bit worried for the
time penalty. But if it's a problem, we can fall back to the other
I likes #1.
On Thu, Apr 23, 2009 at 3:58 PM, Freeland Abbott fabb...@google.com wrote:
Er. Can I take back my approval? It looks like test.hosted already and
also runs the Emma tests, and the test.hosted.emma target has a bad test.out
value.
We can, I think, do any one of:
1. have
I like #1 as is, but would like it better with a minor modification. I
think there should be 2 explicit named targets for emma stuff: one
consisting of the short tests and the other consisting of long tests. The
short tests should always run while the long tests should at least run
during the
