[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread BobV
The cast to (T) is JsVisitor.accept() is necessary for javac 1.5.0_13 as shipped on OS X to compile the code. Otherwise, LGTM. What are your current thoughts on making runAsync work with XS and SSO linkers, since they use function closures? I'll follow up with an updated SOYC reports CL

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread Lex Spoon
On Wed, Oct 29, 2008 at 4:26 PM, Ray Cromwell [EMAIL PROTECTED] wrote: Lex, I can just hack it for now. Long term, I would prefer a solution that addresses in a general purpose fashion, the needs of GWT to be aware of the container it is in, such as the ability to fetch external resources, or

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread Lex Spoon
On Thu, Oct 30, 2008 at 11:28 AM, BobV [EMAIL PROTECTED] wrote: The cast to (T) is JsVisitor.accept() is necessary for javac 1.5.0_13 as shipped on OS X to compile the code. Otherwise, LGTM. Excellent. I put back the (T), with a comment, and committed at revision 3901. What are your

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-29 Thread Ray Cromwell
On Mon, Oct 27, 2008 at 2:35 PM, Lex Spoon [EMAIL PROTECTED] wrote: Ray, I looked at this code today, and I don't believe that it is currently possible for users to (easily) override the function. If you get to the point where you need it before it is implemented, let's look at it. It

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-27 Thread Lex Spoon
On Fri, Oct 17, 2008 at 5:40 PM, Lex Spoon [EMAIL PROTECTED] wrote: On Fri, Oct 17, 2008 at 3:46 PM, Ray Cromwell [EMAIL PROTECTED] wrote: BTW, the code that loads the async fragments must be proxy-aware for this to work. The GadgetLinker generateScriptInjector/generateStylesheetInjector

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-21 Thread Cameron Braid
Are there any design docs for runAsync ? Cheers Cameron On Sat, Oct 18, 2008 at 2:24 AM, Lex Spoon [EMAIL PROTECTED] wrote: Hi, Bob, Can you be the main reviewer for the merge of the runAsync branch to the trunk? The attached patch is the outstanding difference between trunk and branch,

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-19 Thread Lex Spoon
On Sat, Oct 18, 2008 at 12:33 AM, Ray Cromwell [EMAIL PROTECTED] wrote: Lex, I skimmed the CFA code, and I had perhaps a stupid question. I see that method calls have their targets rescued, but what about exceptions, either runtime, or explicitly thrown? Is it possible that a non-local flow

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-19 Thread Bruce Johnson
On Sun, Oct 19, 2008 at 1:30 PM, Lex Spoon [EMAIL PROTECTED] wrote: Ideally hosted mode would use a deferred command instead of running the callback directly, but deferred commands are not available in Core, but runAsync *is* available in Core. I haven't run across a simple solution to this

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Bruce Johnson
sorry for the useless spammy reply, but I can help it: this is super exciting On Fri, Oct 17, 2008 at 12:24 PM, Lex Spoon [EMAIL PROTECTED] wrote: Hi, Bob, Can you be the main reviewer for the merge of the runAsync branch to the trunk? The attached patch is the outstanding difference

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Ray Cromwell
I'm super excited about this too, as well as a merge of OOPHM to trunk :) Comment below: On Fri, Oct 17, 2008 at 9:24 AM, Lex Spoon [EMAIL PROTECTED] wrote: 2. The linkers are updated for this structure, though most of them simply fail if there is more than one fragment. This is of great

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-17 Thread Lex Spoon
On Fri, Oct 17, 2008 at 3:46 PM, Ray Cromwell [EMAIL PROTECTED] wrote: This is of great concern to me. Is there some fundamental reason why linkers won't work with multiple fragments, or it is just that there was an API change and some of the implementations need to be fixed? For example, I