LGTM

Joel, you'll want to use this in your samples. Tidy tidy tidy.


http://gwt-code-reviews.appspot.com/72804/diff/1/3
File user/src/com/google/gwt/resources/client/CssResource.java (right):

http://gwt-code-reviews.appspot.com/72804/diff/1/3#newcode295
Line 295: boolean ensureInjected();
The return value is a nice touch.

http://gwt-code-reviews.appspot.com/72804/diff/1/4
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/72804/diff/1/4#newcode915
Line 915: sw.println("private boolean injected;");
Isn't it nice that the arbi^H^H^H^H style guide doesn't apply to
generated code?

http://gwt-code-reviews.appspot.com/72804

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to