I can take this review.
On Thu, Dec 4, 2008 at 10:56 AM, BobV [EMAIL PROTECTED] wrote:
The attached patch against the 1.6 branch adds
EmittedArtifact.getLastModified() which is used to set the mtime on
files written to disk by the compiler. This resolves issue 2280.
The default
Looks great, I went ahead and committed at r4250. I actually tweaked
StandardGeneratedResource such that the constructor takes a File instead of
a URL, which simplifies the calling code and allows a simple
file.lastModified() implementation. Please make sure my tweak is sane.
On Thu, Dec 4,
Make that r4250 + r4251; I forgot to commit the calling code in
StandardGeneratorContext.
On Thu, Dec 4, 2008 at 1:46 PM, Scott Blum [EMAIL PROTECTED] wrote:
Looks great, I went ahead and committed at r4250. I actually tweaked
StandardGeneratedResource such that the constructor takes a File
On Thu, Dec 4, 2008 at 1:46 PM, Scott Blum [EMAIL PROTECTED] wrote:
Make that r4250 + r4251; I forgot to commit the calling code in
StandardGeneratorContext.
LGTM
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
