[gwt-contrib] Re: RR : Pass in caller for SOYC makeChild() and createSynthetic() functions

2008-10-16 Thread BobV
> Your space bar is on a hair trigger. > - Class comment of JsInliner has a semicolon starting a line > - Method comment of JsInliner.InvocationCountingVisitor.removeCountsFor > starts a line with a period. Eclipse treats JavaDoc directives and html tags as acceptable places for linebreaks. I

[gwt-contrib] Re: RR : Pass in caller for SOYC makeChild() and createSynthetic() functions

2008-10-16 Thread Lex Spoon
Kathrin and I pair reviewed it. LGTU. The particular choice of which class literal to pass in is probably not good to get into. They all look fine, and we can iterate over them based on how the reports look. So that you know, though, in a few classes there is a kind of inconsistent choice made