[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

LGTM Talked offline. Agree that your change is pretty safe. But please be sure to land the corresponding addon-gwt change in lock step. On Mon, Sep 27, 2010 at 2:49 PM, Ray Ryan rj...@google.com wrote: Let's hold off on this one until we find a real solution to the bad create api issue. The

[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

Let's hold off on this one until we find a real solution to the bad create api issue. The sketch in https://jira.springsource.org/browse/ROO-1456 will not do it. On Mon, Sep 27, 2010 at 12:13 PM, Ray Ryan rj...@google.com wrote: On Mon, Sep 27, 2010 at 12:10 PM, amitman...@google.com wrote:

[gwt-contrib] Re: Removed all the Request sub-types. Fixed the generator and the server code where we were relying... (issue926801)

http://gwt-code-reviews.appspot.com/926801/diff/1/12 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/926801/diff/1/12#newcode241 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:241: if