http://gwt-code-reviews.appspot.com/568801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/568801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a
Renderer/Parser? Assuming you mean that we would have subclasses for each
type as we do with ValueBox, I agree. But that means that we'll have a
DateCell and NumberCell anyway, so this patch can go in and we can add a
On Wed, May 26, 2010 at 12:29 PM, John LaBanca jlaba...@google.com wrote:
Hmmm... are you suggesting a ValueCell/ValueInputCell that defers to a
Renderer/Parser? Assuming you mean that we would have subclasses for each
type as we do with ValueBox, I agree. But that means that we'll have a
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
Thanks,
John LaBanca
jlaba...@google.com
On Wed, May 26, 2010 at 3:39 PM, Ray Ryan rj...@google.com wrote:
On Wed, May 26, 2010 at 12:29 PM, John LaBanca
FYI - jat only reviewed the NumberCell class
Thanks,
John LaBanca
jlaba...@google.com
On Wed, May 26, 2010 at 3:41 PM, John LaBanca jlaba...@google.com wrote:
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
Thanks,
On Wed, May 26, 2010 at 12:41 PM, John LaBanca jlaba...@google.com wrote:
Do you agree that we would still have a NumberParser even with the
renderers?
Uh, what?
*NumberParser = NumberCell
I'm not sure I do, actually. It may be easy enough to do new
ValueCellNumber(new NumberParser())
