[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-05-11 Thread rchandia
PTAL. Changes posted in http://gwt-code-reviews.appspot.com/1442804 http://gwt-code-reviews.appspot.com/1426803/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java File user/src/com/google/gwt/uibinder/rebind/FieldWriter.java (right): http://gwt-code-reviews.appspot.com/1426803/dif

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-05-02 Thread rchandia
Review will continue at http://gwt-code-reviews.appspot.com/1427810 On 2011/04/26 23:07:59, rjrjr wrote: Turns out the useLazyWidget stuff isn't passing all of the UiBinder tests yet. Ignoring that path for now seems reasonable. Sorry for the flip flop. On Mon, Apr 25, 2011 at 3:19 PM,

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-04-26 Thread Ray Ryan
Turns out the useLazyWidget stuff isn't passing all of the UiBinder tests yet. Ignoring that path for now seems reasonable. Sorry for the flip flop. On Mon, Apr 25, 2011 at 3:19 PM, wrote: > Oh, the base class exists already: > > com.google.gwt.text.shared.AbstractSafeHtmlRenderer > > > http://g

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-04-25 Thread rjrjr
Oh, the base class exists already: com.google.gwt.text.shared.AbstractSafeHtmlRenderer http://gwt-code-reviews.appspot.com/1426803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-04-25 Thread rjrjr
At the very least there should be an integration test that has something comparable to DomBasedUi and the tests that work it. It should also exercise . http://gwt-code-reviews.appspot.com/1426803/diff/1/user/src/com/google/gwt/uibinder/UiBinder.gwt.xml File user/src/com/google/gwt/uibinder/UiBi