[gwt-contrib] Re: Simplify addition/concatenation of JsLiterals in JsAST

2009-10-29 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/88803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Simplify addition/concatenation of JsLiterals in JsAST

2009-10-28 Thread bobv
http://gwt-code-reviews.appspot.com/88803/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsStaticEval.java (right): http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode417 Line 417: Extra whitespace. http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode495 Line 495: } As a sanity

[gwt-contrib] Re: Simplify addition/concatenation of JsLiterals in JsAST

2009-10-28 Thread cromwellian
The + -0 case won't optimize because there isn't unary operator optimizer that will treat negative zero as zero. On 2009/10/28 13:41:31, bobv wrote: http://gwt-code-reviews.appspot.com/88803/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsStaticEval.java (right):