LGTM
I do want to re-iterate Lex's point that we need to make sure that the
dashboard does not produce different results with this. This is
especially true because we know that the output of the SOYC files has
changed with this patch.
Having said that, this should really speed up compilation,
I have verified that the xml files for a single-permutation Showcase
build are identical modulo whitespace to a set of golden xml files.
I would be happy to run the dashboard on a larger compile -- how do I
run it?
I already submitted a CL, so I will make this changes in a follow-up CL.
Dan
On Mon, Jun 1, 2009 at 3:16 PM, Daniel Rice (דניאל רייס)
r...@google.com wrote:
I have verified that the xml files for a single-permutation Showcase
build are identical modulo whitespace to a set of golden xml files.
I would be happy to run the dashboard on a larger compile -- how do I
run
LGTM, with a few things needed:
1. There should be a test case for writeUtf8.
2. It's worth double checking that locally caching the StringBuilder
helps.
3. Please double check the output if that hasn't been done already; for
example, run the SOYC dashboard, or compare auto-formatted versions of
Thanks, Lex, for picking up the slack on this.
kathrin
On Fri, May 29, 2009 at 6:09 PM, sp...@google.com wrote:
LGTM, with a few things needed:
1. There should be a test case for writeUtf8.
2. It's worth double checking that locally caching the StringBuilder
helps.
3. Please double check
Any numbers on the amount of improvement?
On Tue, May 26, 2009 at 11:04 AM, r...@google.com wrote:
Reviewers: spoon, kprobst, scottb,
Description:
This patch incorporates Kathrin's StringBuilder work along with other
miscellaneous speedups found by using JProfiler.
Please review this at
I see around 2x for the story generation phase. It's hard to measure at
the moment because I haven't been able to get a working before build so I
am estimating based on some numbers jotted down earlier.
Dan
On Tue, May 26, 2009 at 2:27 PM, Bruce Johnson br...@google.com wrote:
Any numbers
