[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread skybrian
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread t . broyer
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
Alternatively, take a look at Patch Set #1, which simply added an extra parameter to exec() to pass in a custom JavaCompiler instance. Would that patch (updated to make the exec() methods public) be preferable? http://gwt-code-reviews.appspot.com/1859803/ --

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread skybrian
On 2012/10/24 21:24:02, mdempsky wrote: Alternatively, take a look at Patch Set #1, which simply added an extra parameter to exec() to pass in a custom JavaCompiler instance. Would that patch (updated to make the exec() methods public) be preferable? Yeah, seems simpler.

[gwt-contrib] Re: Split ValidationTool.exec() into two methods so alternative (issue1859803)

2012-10-24 Thread mdempsky
http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors