On 2011/05/03 03:05:57, jlabanca wrote:
Lots of nits, but looks pretty good overall. I haven't tried it out
yet, but
it'll be a big improvement over truncating excess tabs.
Test cases would also be much appreciated.
http://gwt-code-reviews.appspot.com/1403801/diff/1/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
Lots of nits, but looks pretty good overall. I haven't tried it out
yet, but it'll be a big improvement over truncating excess tabs.
Test cases would also be much appreciated.
http://gwt-code-reviews.appspot.com/1403801/diff/1/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
File
Sorry, I spent all last week working on my Google I/O presentation. I
should be able to do this review this week (for real this time).
Thanks,
John LaBanca
jlaba...@google.com
On Mon, Apr 18, 2011 at 11:54 AM, jlaba...@google.com wrote:
Its on my todo list. I'll try it out this week.
On
On 2011/04/04 18:51:01, Jeff Larsen wrote:
ping
http://gwt-code-reviews.appspot.com/1403801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
John, can you take this?
On 2011/04/18 15:47:48, Jeff Larsen wrote:
On 2011/04/04 18:51:01, Jeff Larsen wrote:
ping
http://gwt-code-reviews.appspot.com/1403801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Its on my todo list. I'll try it out this week.
On 2011/04/18 15:51:09, rjrjr wrote:
John, can you take this?
On 2011/04/18 15:47:48, Jeff Larsen wrote:
On 2011/04/04 18:51:01, Jeff Larsen wrote:
ping
http://gwt-code-reviews.appspot.com/1403801/
--
Here are the images you'll need to get this to compile. Please don't release
with these images as they are hideous.
On Mon, Apr 4, 2011 at 1:51 PM, larse...@gmail.com wrote:
Reviewers: jlabanca, rjrjr, jgw,
Description:
I've fixed up the TabLayoutPanel to handle overflow. I've tested it both
