[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread rjrjr
WHOA! Nevermind, git diff problems. http://gwt-code-reviews.appspot.com/78803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread jlabanca
LGTM But consider the one comment http://gwt-code-reviews.appspot.com/78804/diff/5/6 File user/src/com/google/gwt/user/client/ui/Image.java (right): http://gwt-code-reviews.appspot.com/78804/diff/5/6#newcode355 Line 355: public Image(ImageResource resource) { I think it would be better to

[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread rjrjr
Committed r6327 http://gwt-code-reviews.appspot.com/78804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---