[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread rjrjr
LGTM You and Rafa are on a collision course around the field precedence thing. Let the race begin! http://gwt-code-reviews.appspot.com/1420810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread hermes
http://gwt-code-reviews.appspot.com/1420810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread hermes
On 2011/04/26 22:11:30, hermes wrote: Yes, Rafa won the race! The bug is already fixed and FieldWriterType doesn't bring any big gain. So I reverted the most of the files. The only change here is the use of LazyDomElement to make all places using the same pattern.

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1420810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This fix a bug in WidgetPlaceholderInterpreter (missing convertField) (issue1420810)

2011-04-26 Thread rdcastro
LGTM http://gwt-code-reviews.appspot.com/1420810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors