[gwt-contrib] Re: UiBinder - register custom ElementParser (issue1454804)

2011-06-10 Thread Ray Ryan
As soon as we have done that, we can't make changes to UiBinderWriter and all the other classes the parsers actually talk to, nor can we make sweeping changes to the code they generate. If the problem is retrofitting widgets you don't own, would a non-annotation alternative to UiChild get the job

[gwt-contrib] Re: UiBinder - register custom ElementParser (issue1454804)

2011-06-10 Thread Thomas Broyer
On Fri, Jun 10, 2011 at 7:22 PM, Ray Ryan rj...@google.com wrote: As soon as we have done that, we can't make changes to UiBinderWriter and all the other classes the parsers actually talk to, nor can we make sweeping changes to the code they generate. If the problem is retrofitting widgets you

[gwt-contrib] Re: UiBinder - register custom ElementParser (issue1454804)

2011-06-10 Thread Ray Ryan
Exactly. And I was thinking we could introduce something like BuildsWidgetW extends IsWidget extends IsWidget. UiBinder could learn to honor the setters and such of the underlying widget as well as the BuildsWidget. On Fri, Jun 10, 2011 at 10:41 AM, Thomas Broyer t.bro...@gmail.com wrote: On

[gwt-contrib] Re: UiBinder - register custom ElementParser (issue1454804)

2011-06-09 Thread t . broyer
[+cc google-web-toolkit-contributors] I don't know why I've been added as a reviewer here, but here are a few comments. (beware, I'm not in the GWT Team) http://gwt-code-reviews.appspot.com/1454804/diff/7002/user/src/com/google/gwt/uibinder/elementparsers/AbsolutePanelParser.java File

[gwt-contrib] Re: UiBinder - register custom ElementParser (issue1454804)

2011-06-09 Thread rjrjr
Justin, I really appreciate the contribution, and this is a nice mechanism. But the reason we haven't done something like this already is that we don't want to lock down the api to the parsers. In fact at the moment it's in a lot of flux as we add features to support Cell authors, and as we try