LGTM On Thu, Mar 3, 2011 at 10:52 AM, <b...@google.com> wrote:
> Reviewers: rjrjr, > > Description: > Use RequestContext-local AutoBeanFactory. > Fix unmade change due to branch merge problem. > Patch by: bobv > Review by: rjrjr > > > Please review this at http://gwt-code-reviews.appspot.com/1368805/ > > Affected files: > M > user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java > > > Index: > user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java > =================================================================== > --- > user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java > (revision 9792) > +++ > user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java > (working copy) > @@ -180,8 +180,8 @@ > if (obj == null) { > return LazySplittable.NULL; > } else if (obj.getClass().isEnum() > - && getRequestFactory().getAutoBeanFactory() instanceof EnumMap) > { > - value = ValueCodex.encode(((EnumMap) > getRequestFactory().getAutoBeanFactory()).getToken((Enum<?>) obj)); > + && getAutoBeanFactory() instanceof EnumMap) { > + value = ValueCodex.encode(((EnumMap) > getAutoBeanFactory()).getToken((Enum<?>) obj)); > } else if (ValueCodex.canDecode(obj.getClass())) { > value = ValueCodex.encode(obj); > } else { > @@ -525,7 +525,7 @@ > if (previous == null) { > // Compare to empty object > Class<?> proxyClass = stableId(bean).getProxyClass(); > - previous = > getRequestFactory().getAutoBeanFactory().create(proxyClass); > + previous = getAutoBeanFactory().create(proxyClass); > } > if (!AutoBeanUtils.diff(previous, bean).isEmpty()) { > return true; > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
