On Thu, Apr 21, 2011 at 1:50 PM, Daniel Rice (דניאל רייס)
r...@google.com wrote:
I ran a Showcase compile with log level 'info' 4 times each way, and
took the average of the 3 best times for each way:
Without 'if' tests: 396 seconds
With 'if' tests: 350 seconds
wow, this is fantastic.
The actual code changes LGTM, but I am skeptical about the performance
benefits of guarding all the ones that do nothing more than string
concats. If that is really too expensive, then virtually no log call
should be unguarded, and we should just require callers to insert their
own guards and