For the heap, I think that would be a good change. The stack though in
general, is not something programs should have to mess with.
On Tue, Feb 3, 2009 at 11:59 AM, Freeland Abbott gwt.team.fabb...@gmail.com
wrote:
Looks good, but can we make heap and stack be parameters to gwt.junit? For
I'll LGTM either way, since you've only got one test anyway... but in GWT
projects, I've seen more than one stack change required recently.
On Tue, Feb 3, 2009 at 12:33 PM, Emily Crutcher e...@google.com wrote:
For the heap, I think that would be a good change. The stack though in
general, is
Adding heap param:
http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1468
The difference is with heap, the amount of memory is proportional to the
size of the tests and has a significant cost to set to high.
With stack, the size is proportional to nothing user visible, just a
LGTM as promised.
My argument for the stack parameterization, though, is that once
parameterized most uses can be silent and just use the default, but if
somebody *does* care, then they can easily set it. The argument about
performance says this may not matter much, though.
On Tue, Feb 3, 2009
