Reviewers: jgw, Message: Review, please.
Description: HasHTML extends HasText, so there is no need for these widgets to declare both interfaces. And the fact that they do makes UiBinder treat their content as text rather than HTML. The UiBinder fix would be hard, maybe even completely impractical. Fixing the widgets is easy, so... Please review this at http://gwt-code-reviews.appspot.com/89821 Affected files: M user/src/com/google/gwt/user/client/ui/Anchor.java M user/src/com/google/gwt/user/client/ui/CustomButton.java M user/src/com/google/gwt/user/client/ui/DialogBox.java Index: user/src/com/google/gwt/user/client/ui/Anchor.java diff --git a/user/src/com/google/gwt/user/client/ui/Anchor.java b/user/src/com/google/gwt/user/client/ui/Anchor.java index 6e0d800dd45a0401c891c675a2b1fedb713d8909..89a62784a66b828ee0200efe3e3bf9dde5f9e184 100644 --- a/user/src/com/google/gwt/user/client/ui/Anchor.java +++ b/user/src/com/google/gwt/user/client/ui/Anchor.java @@ -37,7 +37,7 @@ import com.google.gwt.i18n.client.HasDirection; * @see Hyperlink */ public class Anchor extends FocusWidget implements HasHorizontalAlignment, - HasName, HasText, HasHTML, HasWordWrap, HasDirection { + HasName, HasHTML, HasWordWrap, HasDirection { /** * Creates an Anchor widget that wraps an existing <a> element. Index: user/src/com/google/gwt/user/client/ui/CustomButton.java diff --git a/user/src/com/google/gwt/user/client/ui/CustomButton.java b/user/src/com/google/gwt/user/client/ui/CustomButton.java index dbcd510d6e16e6d6afe26beb8c40fb8dc0013ddc..c97d6150a722ee4c1170b1d9ee6737b6948eba27 100644 --- a/user/src/com/google/gwt/user/client/ui/CustomButton.java +++ b/user/src/com/google/gwt/user/client/ui/CustomButton.java @@ -105,7 +105,7 @@ public abstract class CustomButton extends ButtonBase { * Represents a button's face. Each face is associated with its own style * modifier and, optionally, its own contents html, text, or image. */ - public abstract class Face implements HasHTML, HasText { + public abstract class Face implements HasHTML { private static final String STYLENAME_HTML_FACE = "html-face"; private final Face delegateTo; private Element face; @@ -827,7 +827,7 @@ public abstract class CustomButton extends ButtonBase { } } - void fireClickListeners(Event nativeEvent) { + void fireClickListeners(@SuppressWarnings("unused") Event nativeEvent) { // TODO(ecc) Once event triggering is committed, should fire a native click event instead. fireEvent(new ClickEvent() { }); Index: user/src/com/google/gwt/user/client/ui/DialogBox.java diff --git a/user/src/com/google/gwt/user/client/ui/DialogBox.java b/user/src/com/google/gwt/user/client/ui/DialogBox.java index 3eb76cb7468767151d593cdd31a40e19fd487e98..f347cb658e1858520e7705d35a5ce122a2bb5b67 100644 --- a/user/src/com/google/gwt/user/client/ui/DialogBox.java +++ b/user/src/com/google/gwt/user/client/ui/DialogBox.java @@ -81,7 +81,7 @@ import com.google.gwt.user.client.Event.NativePreviewEvent; * </p> */ @SuppressWarnings("deprecation") -public class DialogBox extends DecoratedPopupPanel implements HasHTML, HasText, +public class DialogBox extends DecoratedPopupPanel implements HasHTML, MouseListener { /** * Set of characteristic interfaces supported by the {...@link DialogBox} caption --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
