Re: [gwt-contrib] Spam logs: Could not find an exact match rule. Using 'closest' rule

2014-10-02 Thread 'Goktug Gokdogan' via GWT Contributors
Reverting the binding sounds good to me. Please add a comment to the binding; it might probably be bound to something else but not tested. On Wed, Oct 1, 2014 at 9:39 PM, Colin Alworth niloc...@gmail.com wrote: It looks like changes to a few rebind rules are generating some new logspam when

Re: [gwt-contrib] Spam logs: Could not find an exact match rule. Using 'closest' rule

2014-10-02 Thread Colin Alworth
Sorry Goktug, I don't follow - what should the comment indicate? In the old code, IE9 was expressly bound to the IE6 imp, in the new (to be reverted) code, it was expressly *not* bound to the IE6 impl, but it was the closest fallback anyway. Are you suggesting that the comment should point out

Re: [gwt-contrib] Spam logs: Could not find an exact match rule. Using 'closest' rule

2014-10-02 Thread 'Goktug Gokdogan' via GWT Contributors
The comment is just to indicate that IE9 is bound to legacy FocusImplIE6 only because we didn't test is with a more modern implementation. So later when somebody looks at the code for cleanup will not think that we carefully tested and decided to use the Iegacy implementation. On Thu, Oct 2, 2014

Re: [gwt-contrib] Spam logs: Could not find an exact match rule. Using 'closest' rule

2014-10-02 Thread Jens
Maybe someone wants to mark one of the issues as duplicated since some time ago I also created an issue for it as I haven't seen the one that Colin has found. However in our compiles it is not only FocusImpl and LayoutImpl but also InternalJsHashCodeMap and InternalJsStringMap, see:

[gwt-contrib] Spam logs: Could not find an exact match rule. Using 'closest' rule

2014-10-01 Thread Colin Alworth
It looks like changes to a few rebind rules are generating some new logspam when any GWT app compiles. Specifically, I'm seeing FocusImpl and LayoutImpl, though its possible there are others I haven't seen yet. From the dynatable example we can see the FocusImpl spam: gwtc: [java]