That comment is from the original version of the file committed in 2009.
None of the original members from that time are still on the project. So
here's an educated guess.
As John Tamplin said, repeated string concatenation will make some part of
the AST tree particularly deep and since our
Thanks John for the clarification.
On Thu, Oct 31, 2013 at 7:28 PM, John Stalcup stal...@google.com wrote:
That comment is from the original version of the file committed in 2009.
None of the original members from that time are still on the project. So
here's an educated guess.
As John
Dear GWT lovers,
I have a question for the compiler guys : in the CssResource I see a
comment mentioning that very large string concatenation expressions using
'+' cause the GWT compiler to overflow the stack due to deep AST nesting.
So it's preferable to use intermediate concatenation groupings
oh you mean in CssResourceGenerator.java
found it, taking a look
On Wed, Oct 30, 2013 at 1:22 PM, John Stalcup stal...@google.com wrote:
can you link me to that comment? i'm unfamiliar.
On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix
julien.dram...@gmail.comwrote:
Dear GWT lovers,
I
can you link me to that comment? i'm unfamiliar.
On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix julien.dram...@gmail.comwrote:
Dear GWT lovers,
I have a question for the compiler guys : in the CssResource I see a
comment mentioning that very large string concatenation expressions using
Not a compiler expert, but I wouldn't be surprised since in the AST it will
be represented as a binary tree of JBinaryOperation nodes and the visitors
walk the tree recursively. So balancing the tree should result in a smaller
stack.
- Brian
On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix
On Wed, Oct 30, 2013 at 4:26 PM, Brian Slesinsky skybr...@google.comwrote:
Not a compiler expert, but I wouldn't be surprised since in the AST it
will be represented as a binary tree of JBinaryOperation nodes and the
visitors walk the tree recursively. So balancing the tree should result in
a
