[gwt-contrib] [google-web-toolkit] r7154 committed - Merge trunk r7153 into this branch...

2009-11-24 Thread codesite-noreply
Revision: 7154 Author: j...@google.com Date: Tue Nov 24 01:40:32 2009 Log: Merge trunk r7153 into this branch Don't rely on user agent strings to identify JUnitShell clients svn merge --ignore-ancestry -c7153 \ https://google-web-toolkit.googlecode.com/svn/trunk/ .

[gwt-contrib] New Layout Widgets

2009-11-24 Thread Chris
Has a decision been made as the whether or not the new Layout widgets will be in 2.0? Or a subsequent dot release? Thanks, Chris -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avira is showing warning when accessing gwt-generated files

2009-11-24 Thread dflorey
Am I the only one with this issue? On 19 Nov., 17:29, dflorey daniel.flo...@gmail.com wrote: Hi, since a few weeksAviraAntiVir is generating warnings when accessing gwt-generated files: When accessing data from the URL, http:// allcontacts.southpolecarbon.com/sharedcontacts/

Re: [gwt-contrib] Re: Avira is showing warning when accessing gwt-generated files

2009-11-24 Thread Matt Mastracci
The best approach is probably to upload the file in question to Avira's false-positive reporting page: http://analysis.avira.com/samples/index.php On 24-Nov-09, at 8:19 AM, dflorey wrote: Am I the only one with this issue? On 19 Nov., 17:29, dflorey daniel.flo...@gmail.com wrote: Hi,

[gwt-contrib] Re: New Layout Widgets

2009-11-24 Thread Thomas Broyer
On Nov 24, 3:39 pm, Chris chrish...@gmail.com wrote: Has a decision been made as the whether or not the new Layout widgets will be in 2.0?  Or a subsequent dot release? They're already there (MS2 and RC1), so why wouldn't they be in 2.0 final? --

[gwt-contrib] Re: JUnit sessions, take 2

2009-11-24 Thread scottb
Reviewers: jlabanca, jat, http://gwt-code-reviews.appspot.com/112809/diff/1/2 File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right): http://gwt-code-reviews.appspot.com/112809/diff/1/2#newcode54 Line 54: public String desc; Actually it can't be, the client's ip can change over time,

[gwt-contrib] [google-web-toolkit] r7155 committed - Fixes JUnit sessions to not use Cookies, which can be problematic....

2009-11-24 Thread codesite-noreply
Revision: 7155 Author: sco...@google.com Date: Tue Nov 24 12:23:12 2009 Log: Fixes JUnit sessions to not use Cookies, which can be problematic. - The session id is passed through RPC - Session ids are now ints. Suggested by: jlabanca Review by: jlabanca

[gwt-contrib] [google-web-toolkit] r7156 committed - Edited wiki page through web user interface.

2009-11-24 Thread codesite-noreply
Revision: 7156 Author: tamplinjohn Date: Tue Nov 24 12:24:33 2009 Log: Edited wiki page through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=7156 Modified: /wiki/UsingOOPHM.wiki === --- /wiki/UsingOOPHM.wiki Mon Nov

[gwt-contrib] [google-web-toolkit] r7157 committed - tr...@7155 was merged into this branch...

2009-11-24 Thread codesite-noreply
Revision: 7157 Author: sco...@google.com Date: Tue Nov 24 12:40:22 2009 Log: tr...@7155 was merged into this branch Fixes JUnit sessions to not use Cookies, which can be problematic. svn merge --ignore-ancestry -c7155 https://google-web-toolkit.googlecode.com/svn/trunk/ .

[gwt-contrib] Code Review Request: Fix flaxy MessageTransport test

2009-11-24 Thread rdayal
Reviewers: mmendez, Description: Add a delay to make sure the stream is closed before executing the request. Please review this at http://gwt-code-reviews.appspot.com/111808 Affected files: M dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java Index:

[gwt-contrib] UI cleanups

2009-11-24 Thread jat
Reviewers: rdayal, Description: This adds the success flag we discussed (and renamed the method appropriately), and moves all the Swing interaction into the UI thread to avoid a glitchy UI. Please review this at http://gwt-code-reviews.appspot.com/111809 Affected files:

[gwt-contrib] Last chance SOYC-Compile Report cleanup

2009-11-24 Thread kprobst
Reviewers: Lex, Description: Hi Lex, could you review this patch for me? I replaced several user-facing mentions of SOYC with Compile Report to achieve more consistency, especially for people that don't yet know what SOYC is. Thanks, kathrin Please review this at

[gwt-contrib] [google-web-toolkit] r7158 committed - A number of tweaks to the mail sample....

2009-11-24 Thread codesite-noreply
Revision: 7158 Author: j...@google.com Date: Tue Nov 24 14:14:51 2009 Log: A number of tweaks to the mail sample. Fix for the non-standard style names in SplitLayoutPanel. Review: bruce (desk check) http://code.google.com/p/google-web-toolkit/source/detail?r=7158 Added:

[gwt-contrib] [google-web-toolkit] r7159 committed - Merging trunk r7158 into this branch.

2009-11-24 Thread codesite-noreply
Revision: 7159 Author: j...@google.com Date: Tue Nov 24 14:21:51 2009 Log: Merging trunk r7158 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7159 Added: /releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/gwt-logo.png Modified:

[gwt-contrib] Re: UI cleanups

2009-11-24 Thread rdayal
LGTM, with a few nits. Also, I didn't understand why you changed a bunch of things in SwingUI to run on the UI thread. What was the specific reason for this? http://gwt-code-reviews.appspot.com/111809/diff/1/6 File dev/core/src/com/google/gwt/dev/SwingUI.java (right):

[gwt-contrib] JUnit sessions, take 2

2009-11-24 Thread jlabanca
http://gwt-code-reviews.appspot.com/112809/diff/1/2 File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right): http://gwt-code-reviews.appspot.com/112809/diff/1/2#newcode54 Line 54: public String desc; For consistency, this could be final.

[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel

2009-11-24 Thread jlabanca
LGTM Just a couple extra newlines that should be removed before committing. http://gwt-code-reviews.appspot.com/111805/diff/10/1013 File user/src/com/google/gwt/user/client/ui/HasHorizontalAlignment.java (right): http://gwt-code-reviews.appspot.com/111805/diff/10/1013#newcode41 Line 41: *

[gwt-contrib] Re: UI cleanups

2009-11-24 Thread jat
The reason for the UI thread changes is to avoid glitches where the combo box might not have the right width, or sometimes might not have any contents, or the panel isn't created properly, etc. http://gwt-code-reviews.appspot.com/111809/diff/1/6 File dev/core/src/com/google/gwt/dev/SwingUI.java

[gwt-contrib] [google-web-toolkit] r7160 committed - Cleans up javadoc in layout panels (TODOs will be captured as issues)....

2009-11-24 Thread codesite-noreply
Revision: 7160 Author: j...@google.com Date: Tue Nov 24 14:38:02 2009 Log: Cleans up javadoc in layout panels (TODOs will be captured as issues). Fix for non-standard gwt-Tab style name. Review by: bruce (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=7160 Modified:

[gwt-contrib] [google-web-toolkit] r7161 committed - Merging trunk r7160 into this branch.

2009-11-24 Thread codesite-noreply
Revision: 7161 Author: j...@google.com Date: Tue Nov 24 14:41:20 2009 Log: Merging trunk r7160 into this branch. http://code.google.com/p/google-web-toolkit/source/detail?r=7161 Modified: /releases/2.0/branch-info.txt /releases/2.0/user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java

[gwt-contrib] [google-web-toolkit] r7162 committed - UI cleanups -- move all Swing interaction to the UI thread, add a noti...

2009-11-24 Thread codesite-noreply
Revision: 7162 Author: j...@google.com Date: Tue Nov 24 15:01:58 2009 Log: UI cleanups -- move all Swing interaction to the UI thread, add a notification of failure to load modules, and fix log level for favicon.ico 404's. Patch by: jat Review by: rdayal

[gwt-contrib] [google-web-toolkit] r7163 committed - Merge trunk r7162 into this branch...

2009-11-24 Thread codesite-noreply
Revision: 7163 Author: j...@google.com Date: Tue Nov 24 15:07:18 2009 Log: Merge trunk r7162 into this branch UI cleanups. svn merge --ignore-ancestry -c7162 \ https://google-web-toolkit.googlecode.com/svn/trunk/ . http://code.google.com/p/google-web-toolkit/source/detail?r=7163

[gwt-contrib] [google-web-toolkit] r7164 committed - Don't run DOMTest.testGetAbsolutePosition on HtmlUnit....

2009-11-24 Thread codesite-noreply
Revision: 7164 Author: j...@google.com Date: Tue Nov 24 15:10:16 2009 Log: Don't run DOMTest.testGetAbsolutePosition on HtmlUnit. Patch by: jat Review by: amitmanjhi (verbal) http://code.google.com/p/google-web-toolkit/source/detail?r=7164 Modified:

[gwt-contrib] [google-web-toolkit] r7166 committed - Tagging 2.0.0-ms2.

2009-11-24 Thread codesite-noreply
Revision: 7166 Author: sco...@google.com Date: Tue Nov 24 15:20:17 2009 Log: Tagging 2.0.0-ms2. http://code.google.com/p/google-web-toolkit/source/detail?r=7166 Added: /tags/2.0.0-ms2 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7167 committed - Tagging 2.0.0-rc1.

2009-11-24 Thread codesite-noreply
Revision: 7167 Author: sco...@google.com Date: Tue Nov 24 15:21:05 2009 Log: Tagging 2.0.0-rc1. http://code.google.com/p/google-web-toolkit/source/detail?r=7167 Added: /tags/2.0.0-rc1 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7168 committed - Fix Arrays.equals(Object[], Object[]) to handle nulls, this time corre...

2009-11-24 Thread codesite-noreply
Revision: 7168 Author: j...@google.com Date: Tue Nov 24 15:26:15 2009 Log: Fix Arrays.equals(Object[], Object[]) to handle nulls, this time correctly. Patch by: hhc...@google.com Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7168 Modified:

[gwt-contrib] [google-web-toolkit] r7169 committed - Merge trunk r7168 into this branch...

2009-11-24 Thread codesite-noreply
Revision: 7169 Author: j...@google.com Date: Tue Nov 24 15:29:15 2009 Log: Merge trunk r7168 into this branch Fix Arrays.equals(Object[], Object[]) to handle nulls. svn merge --ignore-ancestry -c7168 \ https://google-web-toolkit.googlecode.com/svn/trunk/ .

[gwt-contrib] Revisiting the script-via-iframe default linkage

2009-11-24 Thread Matt Mastracci
Hey all, If I recall correctly, the original reason that GWT used iframe- wrapped scripts was to work around the buggy compression of Javascript some early versions of IE (example: http://support.microsoft.com/default.aspx?scid=kb;en-us;823386Product=ie600) . The number of users on IE 6 SP1

[gwt-contrib] Replace launch method dropdown with discrete buttons

2009-11-24 Thread jat
Reviewers: amitmanjhi, Description: This patch replaces the dropdown box for launch methods with discrete buttons to reduce confusion. When we create other launch methods, we can revisit the UI. Please review this at http://gwt-code-reviews.appspot.com/111810 Affected files:

Re: [gwt-contrib] Revisiting the script-via-iframe default linkage

2009-11-24 Thread Scott Blum
I think this is a good direction to be heading in. It's a bit non-trivial, though, because the plugin expects to be nested in an iframe. I'm sure that's solvable, but it will be some work. On Tue, Nov 24, 2009 at 6:38 PM, Matt Mastracci matt...@mastracci.comwrote: Hey all, If I recall

[gwt-contrib] Re: Replace launch method dropdown with discrete buttons

2009-11-24 Thread amitmanjhi
LGTM. One minor suggestion. I like this version. http://gwt-code-reviews.appspot.com/111810/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java (right): http://gwt-code-reviews.appspot.com/111810/diff/1/2#newcode233 Line 233: loadingMessage.setText(No URLs to Launch);

[gwt-contrib] [google-web-toolkit] r7170 committed - Change launch method dropdown into discrete buttons....

2009-11-24 Thread codesite-noreply
Revision: 7170 Author: j...@google.com Date: Tue Nov 24 17:17:57 2009 Log: Change launch method dropdown into discrete buttons. Patch by: jat Review by: amitmanjhi http://code.google.com/p/google-web-toolkit/source/detail?r=7170 Modified:

[gwt-contrib] Re: Replace launch method dropdown with discrete buttons

2009-11-24 Thread jat
Thanks, committed to trunk at r7170, merged to releases/2.0 at r7171. http://gwt-code-reviews.appspot.com/111810 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r7171 committed - Merge trunk r7170 into this branch...

2009-11-24 Thread codesite-noreply
Revision: 7171 Author: j...@google.com Date: Tue Nov 24 17:20:45 2009 Log: Merge trunk r7170 into this branch Change launch method dropdown into discrete buttons svn merge --ignore-ancestry -c7170 \ https://google-web-toolkit.googlecode.com/svn/trunk/ .