http://gwt-code-reviews.appspot.com/1278801/diff/6001/7003
File user/src/com/google/gwt/user/client/UserAgentAsserter.java (right):
http://gwt-code-reviews.appspot.com/1278801/diff/6001/7003#newcode36
user/src/com/google/gwt/user/client/UserAgentAsserter.java:36: *
TODO(fredsa): Replace with a
LGTM
On 2011/01/25 22:20:56, jlabanca wrote:
http://gwt-code-reviews.appspot.com/1290803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/01/26 06:42:12, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1298802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/01/26 05:55:35, drfibonacci wrote:
LGTM
http://gwt-code-reviews.appspot.com/1326801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2011/01/26 16:50:26, rjrjr wrote:
http://gwt-code-reviews.appspot.com/1326801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9620
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 09:27:21 2011
Log: Fixing a bug in CellBrowser where the user must click on an element
twice to focus on it and enable keyboard support. The problem is that
Element.getTabIndex() returns 0 for non-focusable divs, which causes us
Revision: 9622
Author: unn...@google.com
Date: Wed Jan 26 06:01:10 2011
Log: Add option to use JSONP in ExternalTextResource
Review at http://gwt-code-reviews.appspot.com/1310801
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9622
Added:
Revision: 9621
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 09:30:56 2011
Log: Add more TCK tests
[JSR 303 TCK Result] 90 of 257 (35.02%) Pass with 29 Failures and 12 Errors.
Review at http://gwt-code-reviews.appspot.com/1298802
Review by: rchan...@google.com
Revision: 9623
Author: rj...@google.com
Date: Wed Jan 26 09:24:30 2011
Log: Bump pom.xml version, and fix NPE in samples/expenses
Review at http://gwt-code-reviews.appspot.com/1326801
http://code.google.com/p/google-web-toolkit/source/detail?r=9623
Modified:
/trunk/samples/expenses/pom.xml
r9623
On 2011/01/26 16:53:55, rchandia wrote:
LGTM
On 2011/01/26 16:50:26, rjrjr wrote:
http://gwt-code-reviews.appspot.com/1326801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9624
Author: rj...@google.com
Date: Wed Jan 26 07:25:18 2011
Log: Cherry picking r9623 into releases/2.2, Bump pom.xml version, and fix
NPE in samples/expenses
http://code.google.com/p/google-web-toolkit/source/detail?r=9624
Modified:
/releases/2.2/samples/expenses/pom.xml
Reviewers: rchandia,
Description:
Turn off test that is failing in IE
Please review this at http://gwt-code-reviews.appspot.com/1285802/show
Affected files:
M user/test/org/hibernate/jsr303/tck/tests/validation/ValidateGwtTest.java
Index:
LGTM
On 2011/01/26 18:51:16, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1285802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9625
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 11:03:00 2011
Log: Cherry picking r9614 and r9620 into releases/2.2 5917 and 5916.
http://code.google.com/p/google-web-toolkit/source/detail?r=9625
Modified:
Revision: 9626
Author: ncha...@google.com
Date: Wed Jan 26 08:11:36 2011
Log: Turn off test that is failing in IE
Review at http://gwt-code-reviews.appspot.com/1285802
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9626
Modified:
Reviewers: tobyr,
Message:
Remember when you did this for the web mode compiler? I want to do this
for JdtCompiler as well.
Please review this at http://gwt-code-reviews.appspot.com/1318802/show
Affected files:
M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
Index:
Reviewers: zundel, jbrosenberg,
Description:
Also:
- Some cleanup from decentralizing JNonNullType
- An easier JDT test for the two different kinds of for-each loops
Please review this at http://gwt-code-reviews.appspot.com/1304802/show
Affected files:
M
I see what you did with the accessibility but not why. Can you
illuminate us?
http://gwt-code-reviews.appspot.com/1304802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Oh right, sorry! This is so you can build a partial AST without a
JProgram, the main change I'm still working on.
http://gwt-code-reviews.appspot.com/1304802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1304802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
It looks like you are working on something that might be interesting to me.
Is there any place I can find more information on this change?
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I don't have anything great written up, but here's the gist of it:
Currently, when you do a web mode compile, JDT actually runs twice. First,
it runs from CompilationStateBuilder and compiles all the source code in
your project. The output of this is used to build TypeOracle, which is a
SG, but why not extract it to a shared class instead of copying? The
index is immutable, and you'll end up building it twice (non-trivial
cost) with this change as it's currently written - once for
AbstractCompiler and once for JdtCompiler (right?).
LGTM now. I'll let you and Bob sort out the rest.
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks Scott for this. It's enough for me to understand motivation and (at
least some) implications of this change.
This is something which is certainly within my interest. Actually, what you
described is exactly what I wanted to see for a long time. I parse jribble
nodes twice for exactly the
Reviewers: bobv,
Description:
Add validation jars to the expenses sample build.xml
Please review this at http://gwt-code-reviews.appspot.com/1309802/show
Affected files:
M samples/expenses/build.xml
Index: samples/expenses/build.xml
LGTM
http://gwt-code-reviews.appspot.com/1309802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I need a g4 approve
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9627
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 13:34:27 2011
Log: Add validation jars to the expenses sample build.xml
Review at http://gwt-code-reviews.appspot.com/1309802
Review by: b...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9627
Modified:
Revision: 9628
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 10:35:35 2011
Log: Add SSL support to DevMode.
Issue: 1806
Patch by: jat
Review by: conroy, tobyr
Review at http://gwt-code-reviews.appspot.com/1324801
http://code.google.com/p/google-web-toolkit/source/detail?r=9628
Added:
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy, alexander.orlov,
Description:
Add mnemonics for DevMode swing UI.
Issue: 5150
Patch by: alexander.orlov, jat
Review by: jat, conroy
Please review this at http://gwt-code-reviews.appspot.com/1328801/show
Affected files:
M
Minor update (Alt+R for Restart Server) at
http://gwt-code-reviews.appspot.com/1328801 since I can't edit this
issue.
http://gwt-code-reviews.appspot.com/708801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I plan to kill AbstractCompiler soon :D
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No hard commitments, but I'm looking on the order of a month or thereabout.
On Wed, Jan 26, 2011 at 3:25 PM, Grzegorz Kossakowski
grzegorz.kossakow...@gmail.com wrote:
Thanks Scott for this. It's enough for me to understand motivation and (at
least some) implications of this change.
This is
LGTM , submitting
On 2011/01/21 11:11:51, tbroyer wrote:
http://gwt-code-reviews.appspot.com/1313801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/26 23:15:56, scottb wrote:
I plan to kill AbstractCompiler soon :D
Ok, it's up to you then. I feel squirrely about committing something in
that state unless the next change is literally just hours out.
http://gwt-code-reviews.appspot.com/1318802/show
--
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40020
File
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40020#newcode43
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:43:
Point taken; I killed the old one and made it reference the new one.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: roubert_google.com, staudacher_google.com,
Description:
Update YEAR_MONTH_WEEKDAY_DAY formats, which were affected by an
ICU/CLDR bug.
This was manually created looking specfically at y+M{1,3}E{1,3}d
patterns in CLDR data and using that where the ICU4J computed value
differed. A
Revision: 9629
Author: sco...@google.com
Date: Wed Jan 26 13:03:02 2011
Log: Add JREIndex optimization to JdtCompiler.
http://gwt-code-reviews.appspot.com/1318802/show
Review by: to...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9629
Modified:
Revision: 9630
Author: rj...@google.com
Date: Wed Jan 26 13:12:30 2011
Log: Fix bad gwt-servlet dep problem described in
http://code.google.com/p/google-web-toolkit/issues/detail?id=5918
http://code.google.com/p/google-web-toolkit/source/detail?r=9630
Modified:
Revision: 9631
Author: gwt.mirror...@gmail.com
Date: Wed Jan 26 16:32:37 2011
Log: Cherry picking r9618 into releases/2.2, DateTimeFormat javadoc fix
http://code.google.com/p/google-web-toolkit/source/detail?r=9631
Modified:
/releases/2.2/user/src/com/google/gwt/i18n/client/DateTimeFormat.java
Revision: 9632
Author: rj...@google.com
Date: Wed Jan 26 13:28:57 2011
Log: Cherry picking r9594, r9630 into releases/2.2, fix gwt-servlet dep in
samples/expenses/pom.xml
http://code.google.com/p/google-web-toolkit/source/detail?r=9632
Modified:
/releases/2.2/samples/expenses/pom.xml
Reviewers: rchandia,
Description:
Warn users of JRE 1.5 that their days are numbered
Addresses
http://code.google.com/p/google-web-toolkit/issues/detail?id=5884
Please review this at http://gwt-code-reviews.appspot.com/1328802/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/1328802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
46 matches
Mail list logo
