[gwt-contrib] Re: How to run a single test ?

2011-03-10 Thread Antoine DESSAIGNE
Hi, Anyone? To clarify, it's not my test that is not running. I didn't manage to run any tests. Is it possible, through ant, to execute a single test suite ? How do you launch your tests ? are you doing the complete ant test each time ? Thanks, Antoine. 2011/3/8 Antoine DESSAIGNE

[gwt-contrib] Re: How to run a single test ?

2011-03-10 Thread Thomas Broyer
Some tests require that the sources (gwt-dev/src, gwt-dev/test, gwt-dev/super, gwt-user/src, etc.) be on the classpath. Alternatively, you can indeed run only a few tests with ant, setting the gwt.junit.testcase.includes property (it defaults to **/*Suite.class), something like (from the user

[gwt-contrib] Re: Issue 6115: RequestFactory: .with(propertyRefs) not always honored (issue1377804)

2011-03-10 Thread t . broyer
Thinking a bit more about it, this fix is IMO not enough: it will only resolve properties that have not yet been resolved, which means in the case of two methods returning the same object, if the second method modifies some properties of the object before returning it and those properties have

Re: [gwt-contrib] Re: How to run a single test ?

2011-03-10 Thread Antoine DESSAIGNE
Thanks a lot ! Now it's working fine :) 2011/3/10 Thomas Broyer t.bro...@gmail.com Some tests require that the sources (gwt-dev/src, gwt-dev/test, gwt-dev/super, gwt-user/src, etc.) be on the classpath. Alternatively, you can indeed run only a few tests with ant, setting the

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-10 Thread pdr
http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java File user/src/com/google/gwt/touch/client/TouchScroller.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java#newcode173

[gwt-contrib] Re: Support paths for iterables without a key or an index. (issue1369810)

2011-03-10 Thread rchandia
LGTM. With a nit. http://gwt-code-reviews.appspot.com/1369810/diff/1/user/src/com/google/gwt/validation/client/impl/NodeImpl.java File user/src/com/google/gwt/validation/client/impl/NodeImpl.java (right):

[gwt-contrib] Re: Issue 6092: Inconsistent use of classloaders in RequestFactory (issue1371803)

2011-03-10 Thread BobV
How about http://gwt-code-reviews.appspot.com/1374804 instead to allow developer control over the classloader instead? -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support paths for iterables without a key or an index. (issue1369810)

2011-03-10 Thread nchalko
Opps. Fixed. http://gwt-code-reviews.appspot.com/1369810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9835 committed - add ie9 user.agent with fallback binding to ie8. (in preparation for i...

2011-03-10 Thread codesite-noreply
Revision: 9835 Author: fabio...@google.com Date: Thu Mar 10 03:46:43 2011 Log: add ie9 user.agent with fallback binding to ie8. (in preparation for ie9 support). Review at http://gwt-code-reviews.appspot.com/1369808 http://code.google.com/p/google-web-toolkit/source/detail?r=9835 Modified:

[gwt-contrib] [google-web-toolkit] r9836 committed - Extract ServiceLayer.getDomainClassLoader() to ensure consistent use o...

2011-03-10 Thread codesite-noreply
Revision: 9836 Author: b...@google.com Date: Thu Mar 10 05:45:01 2011 Log: Extract ServiceLayer.getDomainClassLoader() to ensure consistent use of ClassLoaders within the service layer. Issue 6092. Review at http://gwt-code-reviews.appspot.com/1374804 Patch by: bobv Review by: t.broyer

[gwt-contrib] [google-web-toolkit] r9837 committed - Support paths for iterables without a key or an index....

2011-03-10 Thread codesite-noreply
Revision: 9837 Author: ncha...@google.com Date: Thu Mar 10 05:54:28 2011 Log: Support paths for iterables without a key or an index. [JSR 303 TCK Result] 116 of 257 (45.14%) Pass with 14 Failures and 9 Errors. Review at http://gwt-code-reviews.appspot.com/1369810 Review by: rchan...@google.com

[gwt-contrib] Re: Fixing touch scrolling support for devices that support it natively. Our current touch support o... (issue1369809)

2011-03-10 Thread jlabanca
http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java File user/src/com/google/gwt/touch/client/TouchScroller.java (right): http://gwt-code-reviews.appspot.com/1369809/diff/1/user/src/com/google/gwt/touch/client/TouchScroller.java#newcode162

[gwt-contrib] Re: Makes gadget linker shardable, derived from CrossSiteIframeLinker (issue1370808)

2011-03-10 Thread zundel
I've taken out the hacks, and backfilled missing logic for processMetas and modified computeScriptBase(). It turns out the old linker was stomping 'base' with the original url to the gadget spec passed to the url query string This updated patch now works with the sample apps in the gwt-gadgets

[gwt-contrib] Re: Issue 6076: EditorDelegate's getPath wrong when subeditor referenced with dotted @Path annotation (issue1364801)

2011-03-10 Thread bobv
LGTM, committing with minor cleanups. http://gwt-code-reviews.appspot.com/1364801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9838 committed - Address issue 6076 where composite paths were not recorded correctly....

2011-03-10 Thread codesite-noreply
Revision: 9838 Author: t.bro...@gmail.com Date: Thu Mar 10 07:36:40 2011 Log: Address issue 6076 where composite paths were not recorded correctly. http://gwt-code-reviews.appspot.com/1364801/ Patch by: t.broyer Review by: bobv http://code.google.com/p/google-web-toolkit/source/detail?r=9838

[gwt-contrib] [google-web-toolkit] r9839 committed - Address issue 6066 where RequestFactoryEditorDriver doesn't collect co...

2011-03-10 Thread codesite-noreply
Revision: 9839 Author: t.bro...@gmail.com Date: Thu Mar 10 07:55:44 2011 Log: Address issue 6066 where RequestFactoryEditorDriver doesn't collect composite paths. http://gwt-code-reviews.appspot.com/1363801 Patch by: t.broyer Review by: bobv

[gwt-contrib] [google-web-toolkit] r9840 committed - Copy/paste detected in NumberLabelParser :-)...

2011-03-10 Thread codesite-noreply
Revision: 9840 Author: rj...@google.com Date: Thu Mar 10 09:08:32 2011 Log: Copy/paste detected in NumberLabelParser :-) It leaks DateTimeFormat from DateLabelParser. I've added couple statements into test and fixed problem. Submitting for scheg...@google.com Review at

[gwt-contrib] Re: Issue 6081: ListEditor subeditors' value is not flushed when used with a RequestFactoryEditorDriver (issue1371801)

2011-03-10 Thread bobv
EditorTest refers to a SimpleFooBarOnlyEditor. Which patch defines that type? http://gwt-code-reviews.appspot.com/1371801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Makes gadget linker shardable, derived from CrossSiteIframeLinker (issue1370808)

2011-03-10 Thread unnurg
http://gwt-code-reviews.appspot.com/1370808/diff/1010/gadgets/src/com/google/gwt/gadgets/linker/computeGadgetsBase.js File gadgets/src/com/google/gwt/gadgets/linker/computeGadgetsBase.js (right):

[gwt-contrib] Re: Issue 6081: ListEditor subeditors' value is not flushed when used with a RequestFactoryEditorDriver (issue1371801)

2011-03-10 Thread t . broyer
On 2011/03/10 20:49:41, bobv wrote: EditorTest refers to a SimpleFooBarOnlyEditor. Which patch defines that type? It was there before r9839 http://code.google.com/p/google-web-toolkit/source/detail?r=9839 See also my mail Re: Severe regressions with editor overhaul at r9666 from Mon, Feb 28,

[gwt-contrib] Re: Issue 6081: ListEditor subeditors' value is not flushed when used with a RequestFactoryEditorDriver (issue1371801)

2011-03-10 Thread BobV
It was there before r9839 http://code.google.com/p/google-web-toolkit/source/detail?r=9839 That type had been renamed in one of the other patches. I'm submitting the patches out-of-order relative to how they were written, so I'll just fix it up. -- Bob Vawter Google Web Toolkit Team --

[gwt-contrib] IE9 support (BETA). (issue1383801)

2011-03-10 Thread fabiomfv
Reviewers: jlabanca, rjrjr, jat, Description: IE9 support (BETA). known issues: IE9 devmode throws non fatal js exception. Please review this at http://gwt-code-reviews.appspot.com/1383801/ Affected files: M dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java M

[gwt-contrib] Re: IE9 support (BETA). (issue1383801)

2011-03-10 Thread rjrjr
John L will need to give the real review, but one nit: http://gwt-code-reviews.appspot.com/1383801/diff/1/dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java (right):

[gwt-contrib] Re: IE9 support (BETA). (issue1383801)

2011-03-10 Thread Fabio Valbuena
It seems the issue you are raising is to give a better warning message. I will file an issue and address this next week. On Mar 10, 2011 5:40 PM, rj...@google.com wrote: John L will need to give the real review, but one nit:

[gwt-contrib] Re: Makes gadget linker shardable, derived from CrossSiteIframeLinker (issue1370808)

2011-03-10 Thread zundel
http://gwt-code-reviews.appspot.com/1370808/diff/1010/gadgets/src/com/google/gwt/gadgets/linker/installGadgetsScript.js File gadgets/src/com/google/gwt/gadgets/linker/installGadgetsScript.js (right):

[gwt-contrib] Clean up pesky UiBinder warnings (issue1380802)

2011-03-10 Thread sbrubaker
Reviewers: rjrjr, Description: Clean up pesky UiBinder warnings Please review this at http://gwt-code-reviews.appspot.com/1380802/ Affected files: M user/src/com/google/gwt/uibinder/elementparsers/InterpreterPipe.java M user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java

[gwt-contrib] Re: Phase 1 of I18n Rewrite - support extended plurals/etc for export to property/etc files (issue1355802)

2011-03-10 Thread jat
http://gwt-code-reviews.appspot.com/1355802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Phase 1 of I18n Rewrite - support extended plurals/etc for export to property/etc files (issue1355802)

2011-03-10 Thread jat
I realized the code generator didn't support the new KeyGenerator annotation, and some things were in the rebind package that should have been in server. http://gwt-code-reviews.appspot.com/1355802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors