[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

2011-05-12 Thread zundel
http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Autoformats user/super and user/test-super (issue1442805)

2011-05-12 Thread zundel
Reviewers: rjrjr, scottb, Description: Autoformats user/super and user/test-super Please review this at http://gwt-code-reviews.appspot.com/1442805/ Affected files: M user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java M

[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)

2011-05-12 Thread rjrjr
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java File user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java (right):

[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)

2011-05-12 Thread zundel
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java File user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java (right):

[gwt-contrib] Re: Autoformats user/super and user/test-super (issue1442805)

2011-05-12 Thread Eric Ayers
I had to drag Alex into this. I thought I'd move the process along by mass formatting from eclipse UI on the package or project level, but that also skips our GWT specific tweaks. On Thu, May 12, 2011 at 12:24 PM, zun...@google.com wrote:

[gwt-contrib] Re: Removing the recently added RPC test for LogRecord, as it seems to (issue1447803)

2011-05-12 Thread Unnur Gretarsdottir
Hmmm - that link doesn't work for me - did this issue get reverted? On Wed, May 11, 2011 at 1:02 PM, schen...@google.com wrote: Reviewers: unnurg, Description: Removing the recently added RPC test for LogRecord, as it seems to cause more problems than it is worth. Please review this at

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

2011-05-12 Thread zundel
http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Misc gwtc cleanups (issue1446802)

2011-05-12 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1446802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

2011-05-12 Thread scottb
LGTM w/nits, no need to re-review. http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right):

[gwt-contrib] [google-web-toolkit] r10179 committed - Misc gwtc cleanups....

2011-05-12 Thread codesite-noreply
Revision: 10179 Author: sco...@google.com Date: Thu May 12 10:09:08 2011 Log: Misc gwtc cleanups. http://gwt-code-reviews.appspot.com/1446802/ Review by: zun...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10179 Modified:

[gwt-contrib] [google-web-toolkit] r10180 committed - Rescues cached entries from jar files that are the same, save for the ...

2011-05-12 Thread codesite-noreply
Revision: 10180 Author: zun...@google.com Date: Thu May 12 10:40:46 2011 Log: Rescues cached entries from jar files that are the same, save for the timestamp. Also updates the key value used for the cache to include the prefix for RerootedResource instances. Review at

[gwt-contrib] Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)

2011-05-12 Thread schenney
Reviewers: unnurg, Description: Adding additional testing for GWT RPC. Some custom serialized objects were previously untested, at least explicitly. Testing put in place now provides coverage to test future changes. Please review this at http://gwt-code-reviews.appspot.com/1441804/ Affected

[gwt-contrib] Re: Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)

2011-05-12 Thread tobyr
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java (right):

[gwt-contrib] Enables on the persistent unit cache by default. (issue1448801)

2011-05-12 Thread zundel
Reviewers: tobyr, scottb, jbrosenberg, Description: Enables on the persistent unit cache by default. Please review this at http://gwt-code-reviews.appspot.com/1448801/ Affected files: M dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java Index:

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-12 Thread zundel
I know the paint is still drying on the last patch I submitted for the Persistent Unit Cache, but no real problems have been reported in... weeks! I think its ready to be on by default. http://gwt-code-reviews.appspot.com/1448801/ --

[gwt-contrib] Re: Adding additional testing for GWT RPC. Some custom serialized objects (issue1441804)

2011-05-12 Thread schenney
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java (right):

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-12 Thread Scott Blum
SGTM. At some point I'll have to deal with versioning for the embedded GWT ASTs, but I can burn that bridge when I come to it. On Thu, May 12, 2011 at 6:48 PM, zun...@google.com wrote: I know the paint is still drying on the last patch I submitted for the Persistent Unit Cache, but no real

[gwt-contrib] Fix checkstyle 'info' warnings (issue1446803)

2011-05-12 Thread rice
Reviewers: rjrjr, Description: Fix checkstyle 'info' warnings Please review this at http://gwt-code-reviews.appspot.com/1446803/ Affected files: M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java M

[gwt-contrib] [google-web-toolkit] r10181 committed - Fix checkstyle 'info' warnings...

2011-05-12 Thread codesite-noreply
Revision: 10181 Author: gwt.mirror...@gmail.com Date: Thu May 12 17:18:09 2011 Log: Fix checkstyle 'info' warnings Review at http://gwt-code-reviews.appspot.com/1446803 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10181 Modified:

[gwt-contrib] Experimental attempt to add EventBus support to Widgets (issue1447804)

2011-05-12 Thread rice
Reviewers: rjrjr, Description: Experimental attempt to add EventBus support to Widgets Modify the MobileWebApp sample to use the new feature Please review this at http://gwt-code-reviews.appspot.com/1447804/ Affected files: M