[gwt-contrib] Add HasEnabled to SuggestBox (issue1567803)

2011-10-12 Thread rjrjr
Thanks for taking this over Stephen. Could you extend SuggestBoxTest to cover it? Also, have you looked at the behavior manually? Does it actually work as expected? In particular I'm wondering what happens if the user tabs into the box. http://gwt-code-reviews.appspot.com/1567803/ --

[gwt-contrib] Re: Add HasEnabled to SuggestBox (issue1567803)

2011-10-12 Thread stephen . haberman
Reviewers: rjrjr, Message: Thanks for taking this over Stephen. Could you extend SuggestBoxTest to cover it? Also, have you looked at the behavior manually? Does it actually work as expected? In particular I'm wondering what happens if the user tabs into the box. All good ideas, I'll

[gwt-contrib] Re: Added a getter for the ResettableEventBus object. (issue1569803)

2011-10-12 Thread rjrjr
Thanks for the patch. Please be sure to run ant test (which will tell you that you need to put this method in alphabetical order). And please extend ActivityManagerTest, particularly checking that the returned bus actually is reset as expected.

[gwt-contrib] Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread rjrjr
Reviewers: tobyr, Description: Improves Dev Mode reporting of JavaScriptException to include method name and args. Review by: to...@google.com Please review this at http://gwt-code-reviews.appspot.com/1570803/ Affected files: M dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java

[gwt-contrib] Fixed a typo in exclude NonTckTest flag, that was causing the TCK results count to be wrong. (issue1571803)

2011-10-12 Thread nchalko
Reviewers: rjrjr, Description: Fixed a typo in exclude NonTckTest flag, that was causing the TCK results count to be wrong. Format the METHOD_FILTER and improved variable names in TckTestSuiteWrapper. [JSR 303 TCK Result] 151 of 257 (58.75%) Pass with 32 Failures and 7 Errors. Please review

[gwt-contrib] Re: Fixed a typo in exclude NonTckTest flag, that was causing the TCK results count to be wrong. (issue1571803)

2011-10-12 Thread rjrjr
LGTM Oopsie. http://gwt-code-reviews.appspot.com/1571803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added a getter for the ResettableEventBus object. (issue1569803)

2011-10-12 Thread rjrjr
On 2011/10/12 21:47:29, maximilian.ruppaner wrote: LGTM http://gwt-code-reviews.appspot.com/1569803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add HasEnabled to SuggestBox (issue1567803)

2011-10-12 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1567803/diff/4001/user/src/com/google/gwt/user/client/ui/SuggestBox.java File user/src/com/google/gwt/user/client/ui/SuggestBox.java (left):

[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread rjrjr
Ready for review Mr. Toby. http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread tobyr
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java (right):

[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread rjrjr
http://gwt-code-reviews.appspot.com/1570803/diff/1/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java (right):

[gwt-contrib] Include non-client side types in dependencies (issue1569804)

2011-10-12 Thread stephen . haberman
Reviewers: zundel, Message: This is just a spike, but client-side code now gets successfully recompiled if its binary-only annotations go-away/appear/change. A few notes: All of the getResourceAsStream calls (especially for the made up simple/qualified refs that come out of JDT) took up a lot

[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread rjrjr
http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Improves Dev Mode reporting of JavaScriptException to include method (issue1570803)

2011-10-12 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/1570803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add HasEnabled to SuggestBox (issue1567803)

2011-10-12 Thread stephen . haberman
I published a demo here: http://sh-hello.appspot.com/ http://gwt-code-reviews.appspot.com/1567803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors