[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by martin.g...@gmail.com: @elmacho: for me the plugin is not even installing - ubuntu 9.04, 64bit, ff 3.0.14 it complains about being not for this version (which obviously is true ;) ) did you do anything else to get it working? i still don't get the tab in the debug mode when i

[gwt-contrib] Re: Announcing GWT 2.0 Milestone 1

2009-10-08 Thread Konstantin.Scheglov
* Changes to the distribution: Note that there's only one download, and it's no longer platform-specific. You download the same zip file for every development platform. This is made possible by the new plugin approach used to implement development mode (see below). The distribution file

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by dygger: @jgw I think it makes sense to have view objects initialized from a .ui.xml file as a whole. Since `DialogBox` is a view, why do I have to describe dialog's content in xml and at the same time initialize dialog itself (set its caption, other view related properties like

[gwt-contrib] Re: Announcing GWT 2.0 Milestone 1

2009-10-08 Thread Konstantin.Scheglov
On 8 окт, 17:46, John Tamplin j...@google.com wrote:  FF 3.5.3 can not install plugin.  When I try to install extension, it goes further, but still fails with some deferred binding exception. Can you clarify what you mean here?  When you try and install the FF3.5 plugin from the

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by dygger: BTW, I have found a workaround for the DialogBox problem. At first I had to create a subclass for DialogBox implementing HasWidgets interface: {{{ public class HasWidgetsDialogBox extends com.google.gwt.user.client.ui.DialogBox implements HasWidgets {

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by tamplinjohn: What is the exact message it gives you when rejecting the addon? I don't have an Ubuntu9 machine to test on, but you could try and see if the version with alternate libraries (needed for Fedora 10 at least) works:

[gwt-contrib] Re: GWT OOPHM Plugin for IE Windows Installer

2009-10-08 Thread jat
I have not looked at the code, only running the installer. - OOPHM everywhere, never saw a mention of GWT Development Mode Plugin - Icon looks lousy we have large ones available that can be scaled to the size you need Other than that, looks good. http://gwt-code-reviews.appspot.com/78801

[gwt-contrib] [google-web-toolkit] r6322 committed - Add better error handling for future protocol version where we support...

2009-10-08 Thread codesite-noreply
Revision: 6322 Author: j...@google.com Date: Thu Oct 8 08:49:57 2009 Log: Add better error handling for future protocol version where we support downloading the real plugin via a shim plugin. http://code.google.com/p/google-web-toolkit/source/detail?r=6322 Modified:

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by rj...@google.com: I agree on the DialogBox use case, and will try to make it work. Thanks for the workaround. For more information: http://code.google.com/p/google-web-toolkit/wiki/UiBinder --~--~-~--~~~---~--~~

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by rj...@google.com: Oh, and yes: UiBinder gets along just fine with MVP. One thing I want to start experimenting with is having binder instances injected by GIN, e.g.: {{{ MyView extends Widget { public interface Binder extends UiBinderMyView, Widget {} private static final

[gwt-contrib] [google-web-toolkit] r6323 committed - Various fixes for deRPC....

2009-10-08 Thread codesite-noreply
Revision: 6323 Author: b...@google.com Date: Thu Oct 8 10:06:39 2009 Log: Various fixes for deRPC. - If an array type is artificially rescued, it should rescue its component type. - Don't generate bad RPC proxy code if the legacy type-elision flag is set. - Correctly handle

[gwt-contrib] [google-web-toolkit] r6324 committed - Merge r6323 into snapshot branch....

2009-10-08 Thread codesite-noreply
Revision: 6324 Author: b...@google.com Date: Thu Oct 8 10:32:14 2009 Log: Merge r6323 into snapshot branch. $ svn merge -c 6323 https://google-web-toolkit.googlecode.com/svn/trunk http://code.google.com/p/google-web-toolkit/source/detail?r=6324 Modified: /branches/snapshot-2009.10.06-r6307

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by myonceinalifetime: I got debugging to work! I created a new GWT web app with the Eclipse google plugin using GWT 2.0MS1 as the SDK. This is what most likely solved my problem. Simply changing a project from GWT 1.7.1 to 2.0 must not be making all the necessary changes to the

[gwt-contrib] [google-web-toolkit] r6325 committed - Update branch-info.txt.

2009-10-08 Thread codesite-noreply
Revision: 6325 Author: b...@google.com Date: Thu Oct 8 10:35:28 2009 Log: Update branch-info.txt. http://code.google.com/p/google-web-toolkit/source/detail?r=6325 Modified: /branches/snapshot-2009.10.06-r6307/branch-info.txt === ---

[gwt-contrib] Teach Image about ImageResource

2009-10-08 Thread rjrjr
Reviewers: jlabanca, Message: John, can you take this? Please review this at http://gwt-code-reviews.appspot.com/78803 Affected files: M build.xml M dev/core/src/com/google/gwt/dev/javac/ArtificialRescueChecker.java M

[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread rjrjr
WHOA! Nevermind, git diff problems. http://gwt-code-reviews.appspot.com/78803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Teach Image about ImageResource

2009-10-08 Thread rjrjr
Reviewers: jlabanca, Message: Okay, ready for my close up Mr. Labanca Please review this at http://gwt-code-reviews.appspot.com/78804 Affected files: M user/src/com/google/gwt/user/client/ui/Image.java M user/test/com/google/gwt/user/client/ui/ImageTest.java A

[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread jlabanca
LGTM But consider the one comment http://gwt-code-reviews.appspot.com/78804/diff/5/6 File user/src/com/google/gwt/user/client/ui/Image.java (right): http://gwt-code-reviews.appspot.com/78804/diff/5/6#newcode355 Line 355: public Image(ImageResource resource) { I think it would be better to

[gwt-contrib] Re: Teach Image about ImageResource

2009-10-08 Thread rjrjr
Committed r6327 http://gwt-code-reviews.appspot.com/78804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Switch CssResource to strict-by-default mode

2009-10-08 Thread rjrjr
LGTM Just nits. http://gwt-code-reviews.appspot.com/75804/diff/1/3 File user/src/com/google/gwt/resources/client/CssResource.java (right): http://gwt-code-reviews.appspot.com/75804/diff/1/3#newcode120 Line 120: * The {...@code @external} at-rule can be used in strict mode to indicate that did

[gwt-contrib] [google-web-toolkit] r6329 committed - Adding UrlBuilder and using it in Showcase and GwtTestCase so we don't...

2009-10-08 Thread codesite-noreply
Revision: 6329 Author: jlaba...@google.com Date: Thu Oct 8 13:06:28 2009 Log: Adding UrlBuilder and using it in Showcase and GwtTestCase so we don't remove gwt.hosted parameter in URLs. Patch by: jlabanca Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=6329

[gwt-contrib] Empty Anchor uses incorrect javascript syntax

2009-10-08 Thread jlabanca
Reviewers: Ray Ryan, Description: Description: The Anchor widget defaults its href to javascript: if no href is specified to prevent a blank page from loading. However, this causes FF2 to open the error console with no error message. Fix: Changed the href to the correct value javascript:;.

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by sven.tiffe: Folks, is there a way to bind more than one element to a method, e.g. {{{ @UiHandler(textField1) @UiHandler(textField2) protected void updateLogin(KeyUpEvent event) { model.validate(); } }}} And is there anything planned for two-way bindings? I was

[gwt-contrib] Comment on UiBinder in google-web-toolkit

2009-10-08 Thread codesite-noreply
Comment by rj...@google.com: {{{ @UiHandler({textField1, textField2}) protected void updateLogin(KeyUpEvent event) { model.validate(); } }}} For more information: http://code.google.com/p/google-web-toolkit/wiki/UiBinder --~--~-~--~~~---~--~~

[gwt-contrib] [google-web-toolkit] r6330 committed - Delay processing the -runStyle argument so JUnitShell's logger is avai...

2009-10-08 Thread codesite-noreply
Revision: 6330 Author: j...@google.com Date: Thu Oct 8 14:16:26 2009 Log: Delay processing the -runStyle argument so JUnitShell's logger is available for the runstyles. http://code.google.com/p/google-web-toolkit/source/detail?r=6330 Modified:

[gwt-contrib] Re: Empty Anchor uses incorrect javascript syntax

2009-10-08 Thread John LaBanca
FYI - I added another patch set. It doesn't seem to send out an email to that effect though Thanks, John LaBanca jlaba...@google.com On Thu, Oct 8, 2009 at 5:05 PM, Ray Ryan rj...@google.com wrote: That's why TDD is a good thing. Not that I've ever managed it. On Thu, Oct 8, 2009 at 1:52

[gwt-contrib] Re: Empty Anchor uses incorrect javascript syntax

2009-10-08 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/77804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit] r6331 committed - Adding a semicolon to the javascript reference in empty Anchor widgets...

2009-10-08 Thread codesite-noreply
Revision: 6331 Author: jlaba...@google.com Date: Thu Oct 8 14:22:37 2009 Log: Adding a semicolon to the javascript reference in empty Anchor widgets to fix a FF2 bug where Anchor widgets open the error console. Patch by: jlabanca Review by: rjrjr

[gwt-contrib] [google-web-toolkit] r6328 committed - Adding installer for OOPHM IE plugin.

2009-10-08 Thread codesite-noreply
Revision: 6328 Author: jlaba...@google.com Date: Thu Oct 8 12:28:52 2009 Log: Adding installer for OOPHM IE plugin. http://code.google.com/p/google-web-toolkit/source/detail?r=6328 Added: /trunk/plugins/ie/installer /trunk/plugins/ie/installer/COPYING.rtf

[gwt-contrib] [google-web-toolkit] r6333 committed - Adds LINE_START and LINE_END to DockPanelParser in UiBinder...

2009-10-08 Thread codesite-noreply
Revision: 6333 Author: rj...@google.com Date: Thu Oct 8 18:15:53 2009 Log: Adds LINE_START and LINE_END to DockPanelParser in UiBinder Internal contribution. reviewed by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=6333 Modified:

[gwt-contrib] Introduces ui:image--ImageResource in UiBinder

2009-10-08 Thread rjrjr
Reviewers: bobv, jgw, Message: Bob or Joel, could one of you grab this? Whoever gets there first... Please review this at http://gwt-code-reviews.appspot.com/77805 Affected files: M user/src/com/google/gwt/uibinder/parsers/HasTextParser.java M

[gwt-contrib] Re: Introduces ui:image--ImageResource in UiBinder

2009-10-08 Thread rjrjr
One note: GetEscapedInnerTextVisitor is just a rename of GetInnerTextVisitor, no need for review beyond that. http://gwt-code-reviews.appspot.com/77805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r6334 committed - We don't need ui:apply after all

2009-10-08 Thread codesite-noreply
Revision: 6334 Author: rj...@google.com Date: Thu Oct 8 18:46:03 2009 Log: We don't need ui:apply after all http://code.google.com/p/google-web-toolkit/source/detail?r=6334 Modified: /wiki/UiBinder.wiki === --- /wiki/UiBinder.wiki Sat Sep 26 07:07:46 2009

[gwt-contrib] [google-web-toolkit] r6335 committed - More plausible use of a sprite class

2009-10-08 Thread codesite-noreply
Revision: 6335 Author: rj...@google.com Date: Thu Oct 8 18:47:51 2009 Log: More plausible use of a sprite class http://code.google.com/p/google-web-toolkit/source/detail?r=6335 Modified: /wiki/UiBinder.wiki === --- /wiki/UiBinder.wiki Thu Oct 8 18:46:03

[gwt-contrib] Re: Switch CssResource to strict-by-default mode

2009-10-08 Thread rjrjr
And don't forget to update your wiki pages http://gwt-code-reviews.appspot.com/75804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---