Comment by vrinda.pujare:
Currently I am using GWT 2.0.3 with tomcat5.5 as a server, IE6 and
WindowsXP 64bit.
I am trying to debug my application in client debug mode. Also I have
followed all the steps to set up debug mode. And started tomcat and
application using DevMode in debug mode.
Reviewers: scottb,
Description:
Have JsInliner refuse to interpose a new expression
before a substituted argument.
Please review this at http://gwt-code-reviews.appspot.com/344801/show
Affected files:
M dev/core/src/com/google/gwt/dev/js/JsInliner.java
M
Can anyone familiar with GWT's optimization review this?
http://gwt-code-reviews.appspot.com/344801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
LGTM, nits.
http://gwt-code-reviews.appspot.com/344801/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right):
http://gwt-code-reviews.appspot.com/344801/diff/1/2#newcode677
dev/core/src/com/google/gwt/dev/js/JsInliner.java:677: public void
endVisit(JsNew x,
Oh, I had one final thought on this, that might be worth a note for the
future, if my logic is sound:
You might imagine having special-cased JsInvocations to an empty target
method to not break evaluation order (since they do nothing). As a
practical matter, however, we didn't bother doing so
Thanks, Scott.
I added the TODO at the place indicated. It applies more broadly,
though: any place the inliner looks at a function call, it would be nice
to know what if any side effects that function call has and would be
affected by.
http://gwt-code-reviews.appspot.com/344801/diff/1/2
File
LGTM
http://gwt-code-reviews.appspot.com/284802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
Revision: 7912
Author: rchan...@google.com
Date: Tue Apr 13 05:32:59 2010
Log: Added method to change the size of a MutableArray. Added factory
method to
construct MeutableArray of specific size. These provide a O(n) way to
initialize
a MutableArray as shown by
Revision: 7913
Author: sp...@google.com
Date: Tue Apr 13 06:08:53 2010
Log: Have JsInliner refuse to interpose a new expression
before a substituted argument.
Review at http://gwt-code-reviews.appspot.com/344801
Review by: sco...@google.com
Revision: 7914
Author: sco...@google.com
Date: Tue Apr 13 07:20:13 2010
Log: Fixes ICE in JsInliner.
We are getting a compiler crash if you try to inline a static JSNI method
that references 'this' (weird case). This change disables inlining such
methods.
Revision: 7915
Author: sp...@google.com
Date: Tue Apr 13 10:38:07 2010
Log: Rolling back in r7776, which improves JsInliner, along with r7913 and
r7914, which fix
bugs in it. The merge commands were:
svn merge --ignore-ancestry -r 7775:7776
Revision: 7916
Author: r...@google.com
Date: Tue Apr 13 08:09:30 2010
Log: Implement selection on trees
Rename 'onDataChange' - 'setData', etc.
Minor stylistic fixes
Review at http://gwt-code-reviews.appspot.com/333802
Review by: j...@google.com
http://gwt-code-reviews.appspot.com/319801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
Dan, Freeland:
Please disregard this last patch. I will not submit it. Actually I do
not know why it got appended to this issue instead of becoming a new
issue.
Do I need to do something else to clean up?
On 2010/04/13 18:36:44, rchandia wrote:
I *think* it's the latter.
On Tue, Apr 13, 2010 at 3:51 PM, Ray Cromwell cromwell...@gmail.com wrote:
What's the motivation for this change? Did some code actually trip
this up, or was this more a result of the new way constructor
functions do work, whereas in the past, the majority of JsNew
Revision: 7917
Author: rj...@google.com
Date: Tue Apr 13 12:46:18 2010
Log: Fix for delegate-of-the-delegate NPE after ListView.Delegate refactor
http://code.google.com/p/google-web-toolkit/source/detail?r=7917
Modified:
Revision: 7918
Author: gwt.mirror...@gmail.com
Date: Tue Apr 13 18:19:04 2010
Log: Reverts r7916 (Implement selection on trees), which causes
ExpensesScaffold to render every table cell with display:none.
http://code.google.com/p/google-web-toolkit/source/detail?r=7918
Added:
17 matches
Mail list logo
