LGTM
http://gwt-code-reviews.appspot.com/1422811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1425808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420809/diff/4006/dev/core/src/com/google/gwt/dev/javac/CompiledClass.java
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10086
Author: her...@google.com
Date: Wed Apr 27 03:02:03 2011
Log: Fixing setInnerHTML calls on attach/detach sections.
Review at http://gwt-code-reviews.appspot.com/1422811
http://code.google.com/p/google-web-toolkit/source/detail?r=10086
Modified:
I am noticing that while unnecessary casts of an EnumType to (Enum) no
longer happen, there is still a cast generated, for the EnumType itself.
Is that necessary?
E.g., I'm seeing code like this:
Fruit fruit = Fruit.APPLE;
int i = fruit.ordinal();
ending up in the AST like this (from
http://gwt-code-reviews.appspot.com/1409802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1409802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1425810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1380806/diff/25001/user/src/com/google/gwt/safehtml/shared/UriUtils.java
File user/src/com/google/gwt/safehtml/shared/UriUtils.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1422807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10088
Author: zun...@google.com
Date: Wed Apr 27 07:16:38 2011
Log: Removed unecessary @Override
http://code.google.com/p/google-web-toolkit/source/detail?r=10088
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/testing/JavaSource.java
committed as r10087
http://gwt-code-reviews.appspot.com/1425808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with nits.
http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java
File user/src/com/google/gwt/resources/client/ImageResource.java
(right):
On 2011/04/26 21:10:21, jlabanca wrote:
On Tue, Apr 26, 2011 at 4:57 PM, Jeff Larsen
mailto:larse...@gmail.com wrote:
Drag n Drop doesn't work in ie8 (expected). Perhaps use deferred
binding to
get rid of the templates portion for all versions of ie9. Otherwise
those templates are pretty
Reviewers: rjrjr,
Description:
Add ability to include SafeHtml objects in dom based UI's if the laay
widget option is being used (this is the only way that the setters will
work correctly)
Please review this at http://gwt-code-reviews.appspot.com/1425811/
Affected files:
M
As long as the JsInliner can still clean it up, I'm fine, otherwise, it
seems like it would introduce some bloat by having trivial delegations. I'm
actually wondering if we should detect the case when a static method ONLY is
referenced by the instance method it was created from via delegation, and
Good news and bad news.
The bad news is that there is much too much copy and paste in this
patch. But the good news is that your task is basically impossible, so
it's not worth trying to fix that. Or is that bad news too? See below.
If the Java MethodInliner kept call counts, I would have special-cased it to
allow inlining the static into the instance when it's the only caller. But
since call counts aren't already computed, I decided it would be best to try
it out as is and see if it actually increases code size in practice.
On Wed, Apr 27, 2011 at 2:57 PM, Scott Blum sco...@google.com wrote:
If the Java MethodInliner kept call counts, I would have special-cased it
to allow inlining the static into the instance when it's the only caller.
But since call counts aren't already computed, I decided it would be best
If I understand correctly, part of staticification is that all
call-sites to myVar.foo(x) will be replaced by $foo(myVar, x), and thus
foo(x) will be unused, and thus pruned. So, the delegation issues goes
away, no?
http://gwt-code-reviews.appspot.com/1428804/
--
This (unfortunately) makes perfect sense:) On the bright side,
implementing a new tag will be much easier than getting ui:text to do
double duty. One note on your comments: UiTextInterpreter can't verify
attribute#hasComputedValue if it runs downstream of
ComputedAttributeInterpreter, because
http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
File
user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
(right):
Revision: 10089
Author: scheg...@google.com
Date: Wed Apr 27 09:34:06 2011
Log: Adds cache of CollectClassData to make refresh faster.
This gives about 10% performance gain on big projects.
Review at http://gwt-code-reviews.appspot.com/1420809
Review by: sco...@google.com
Reviewers: rjrjr,
Description:
Remove FieldWriter.setAttachable() and find out automatically whether
the callbacks should be created.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1421807/
Affected files:
M
http://gwt-code-reviews.appspot.com/1380806/diff/25001/user/src/com/google/gwt/safehtml/shared/UriUtils.java
File user/src/com/google/gwt/safehtml/shared/UriUtils.java (right):
It looks like there might be some logic in
ControlFlowAnalyzer.RescueVisitor.Rescue, which can also be removed if
inlining staticImpl's is not an issue.
http://gwt-code-reviews.appspot.com/1428804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: tobyr, jbrosenberg,
Description:
Discards the jar file name in the resource location. It isn't
necessary, and
will cause detritus to build up in the cache if a resource changes from
being
in one jar to another or moves in/out of a .jar file.
Please review this at
I see now (looking at MakeCallsStatic.RewriteCallSites) that not all
call sites get replaced, there are a few edge cases, relating to split
points, etc., where the call sites are not replacedBut I'm guessing
it won't be a large number of cases.
http://gwt-code-reviews.appspot.com/1428804/
On Wed, Apr 27, 2011 at 3:20 PM, jbrosenb...@google.com wrote:
If I understand correctly, part of staticification is that all
call-sites to myVar.foo(x) will be replaced by $foo(myVar, x), and thus
foo(x) will be unused, and thus pruned. So, the delegation issues goes
away, no?
Yes, as
LGTM
http://gwt-code-reviews.appspot.com/1421807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
New patch, removed the unneeded code from CFA.
http://gwt-code-reviews.appspot.com/1428804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1428804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
File
user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
(right):
LGTM w/ nits
http://gwt-code-reviews.appspot.com/1425810/diff/6/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right):
Reviewers: rjrjr,
Description:
Adds a ui:safehtml tag to UiBinder
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1422812/
Affected files:
M
user/src/com/google/gwt/uibinder/elementparsers/ComputedAttributeInterpreter.java
M
Revision: 10090
Author: rdcas...@google.com
Date: Wed Apr 27 11:32:54 2011
Log: Remove FieldWriter.setAttachable() and find out automatically
whether the callbacks should be created.
Review at http://gwt-code-reviews.appspot.com/1421807
Review by: rj...@google.com
http://gwt-code-reviews.appspot.com/1425811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/27 15:12:57, jbrosenberg wrote:
I am noticing that while unnecessary casts of an EnumType to (Enum) no
longer
happen, there is still a cast generated, for the EnumType itself. Is
that
necessary?
E.g., I'm seeing code like this:
Fruit fruit = Fruit.APPLE;
int i =
New (hopefully final?) patch.
http://gwt-code-reviews.appspot.com/1426804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jbrosenberg, cromwellian,
Message:
The actual types aren't important, the rebind logic is all about
matching up request/result type. Removing the types here makes things
simpler.
Please review this at http://gwt-code-reviews.appspot.com/1427808/
Affected files:
M
+ gwt contrib
http://gwt-code-reviews.appspot.com/1422813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'll patch this in and try to figure out the TextBox thing.
http://gwt-code-reviews.appspot.com/1425811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1425811/diff/5001/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
File
user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java
(right):
http://gwt-code-reviews.appspot.com/1422813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1422813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
TextBox isn't in the fake widget set defined by
com.google.gwt.uibinder.test.UiJavaResources, and Label is. Your new
code reports such errors now, which is great.
http://gwt-code-reviews.appspot.com/1425811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks, Ray. Submitting via SQ
http://gwt-code-reviews.appspot.com/1422813/diff/1/user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java
File
user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java
(right):
Reviewers: rjrjr, rdcastro,
Description:
Making ui:style builders always called in the Widgets ctor. Also add a
final clause in field builders.
Please review this at http://gwt-code-reviews.appspot.com/1422814/
Affected files:
M
http://gwt-code-reviews.appspot.com/1422813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10091
Author: sco...@google.com
Date: Wed Apr 27 13:35:10 2011
Log: Fix a class of compiler bugs related to staticImpl.
Ran into this general class of issue... originally I set out to add
staticImpl handling logic to a couple more places, such as
ImplicitUpcastAnalyzer.
Where is UiSafeHtmlInterpreter?
I imagine it's a copy / paste clone of UiTextInterpreter, and will have
the same bugs that one does. Instead, please make it a subclass of
UiTextInterpreter, overriding a protected
createComputedAttributeInstructor() method.
Please add the unit tests for both
LGTM
http://gwt-code-reviews.appspot.com/1422814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1427808/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java (right):
Hmm - I just noticed this review - sorry!
http://gwt-code-reviews.appspot.com/1424801/diff/1/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java
File user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java (right):
http://gwt-code-reviews.appspot.com/1423810/diff/1/user/src/com/google/gwt/dom/client/SourceElement.java
File user/src/com/google/gwt/dom/client/SourceElement.java (right):
http://gwt-code-reviews.appspot.com/1423810/diff/1/user/src/com/google/gwt/dom/client/SourceElement.java#newcode67
http://gwt-code-reviews.appspot.com/1423810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1422814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427808/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java (right):
http://gwt-code-reviews.appspot.com/1427808/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java#newcode68
Revision: 10093
Author: sco...@google.com
Date: Wed Apr 27 14:46:52 2011
Log: Model JGwtCreate/JReboundEntryPoint request/result types as
strings.
The actual types aren't important, the rebind logic is all about matching
up request/result type. Removing the types here makes
Since you asked so nicely, I can confirm that changing imports and the
gwt.xml file was all I needed to do to fix 2 large gwt applications.
On Tue, Apr 26, 2011 at 8:48 PM, Chris Ramsdale cramsd...@google.com wrote:
Hey GWTC folks,
We have a GWT SDK 2.3.0.RC1 build that we would love feedback
LGTM
http://gwt-code-reviews.appspot.com/1427808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10094
Author: zun...@google.com
Date: Wed Apr 27 15:42:18 2011
Log: Ups a timeout from the requestfactory suite from 10 seconds to 30
seconds
in hopes of eliminating spurious timeouts during unit testing.
http://code.google.com/p/google-web-toolkit/source/detail?r=10094
How does this actually work?
If I implement HasRequestContextT anywhere, the containing request
factory editor driver that is generated no longer compiles, saying
that there is a missing constructor
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1422810/diff/1003/dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java
File dev/core/src/com/google/gwt/core/ext/soyc/HasOverrides.java (left):
We just upgraded 3 apps too, with one gotcha: it turns out that you need to
do a find/replace on com.google.gwt.requestfactory.client. -
com.google.web.bindery.requestfactory.gwt.client. before you do
com.google.gwt.requestfactory.
- com.google.web.bindery.requestfactory.. After that, it seems to
Reviewers: rchandia,
Description:
Correctly handle graph navigation determinism.
[JSR 303 TCK Result] 122 of 257 (47.47%) Pass with 10 Failures and 7
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1420812/
Affected files:
M
71 matches
Mail list logo
