[gwt-contrib] Killing @deprecated urn:with from uibinder tests. (issue1425814)

2011-04-29 Thread hermes
Reviewers: rjrjr, Description: Killing @deprecated urn:with from uibinder tests. Please review this at http://gwt-code-reviews.appspot.com/1425814/ Affected files: M user/test/com/google/gwt/uibinder/test/client/DomBasedUi.ui.xml M

[gwt-contrib] Re: Killing @deprecated urn:with from uibinder tests. (issue1425814)

2011-04-29 Thread rjrjr
Let's leave these in until internal use cleanup has happened. On 2011/04/29 15:16:42, hermes wrote: http://gwt-code-reviews.appspot.com/1425814/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix nested AttachableHTMLPanels step 2: we have to mark the initialization as finished (by havin... (issue1423811)

2011-04-29 Thread rdcastro
Reviewers: rjrjr, Description: Fix nested AttachableHTMLPanels step 2: we have to mark the initialization as finished (by having html = null) after wrapElement is called, otherwise the whole thing will be rebuilt again when getElement is called (for instance, if the AttachableHTMLPanel is added

[gwt-contrib] Re: Fix nested AttachableHTMLPanels step 2: we have to mark the initialization as finished (by havin... (issue1423811)

2011-04-29 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1423811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10112 committed - Update Expenses sample GWT version to 2.3.0

2011-04-29 Thread codesite-noreply
Revision: 10112 Author: rchan...@google.com Date: Fri Apr 29 04:50:42 2011 Log: Update Expenses sample GWT version to 2.3.0 http://code.google.com/p/google-web-toolkit/source/detail?r=10112 Modified: /releases/2.3/samples/expenses/pom.xml /releases/2.3/tools/scripts/maven_script.sh

[gwt-contrib] Re: Correctly handle graph navigation determinism. (issue1420812)

2011-04-29 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1420812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10113 committed - Fix nested AttachableHTMLPanels step 2: we have to mark the initializa...

2011-04-29 Thread codesite-noreply
Revision: 10113 Author: gwt.mirror...@gmail.com Date: Fri Apr 29 05:43:32 2011 Log: Fix nested AttachableHTMLPanels step 2: we have to mark the initialization as finished (by having html = null) after wrapElement is called, otherwise the whole thing will be rebuilt again when

[gwt-contrib] [google-web-toolkit] r10114 committed - Additional infrastructure for generating source code outside of a...

2011-04-29 Thread codesite-noreply
Revision: 10114 Author: gwt.mirror...@gmail.com Date: Fri Apr 29 05:45:27 2011 Log: Additional infrastructure for generating source code outside of a GWT generator. Review at http://gwt-code-reviews.appspot.com/1421805 Review by: unn...@google.com

[gwt-contrib] [google-web-toolkit] r10115 committed - Correctly handle graph navigation determinism....

2011-04-29 Thread codesite-noreply
Revision: 10115 Author: ncha...@google.com Date: Fri Apr 29 07:05:45 2011 Log: Correctly handle graph navigation determinism. [JSR 303 TCK Result] 122 of 257 (47.47%) Pass with 10 Failures and 7 Errors. Review at http://gwt-code-reviews.appspot.com/1420812 Review by:

[gwt-contrib] Adds HTML5 App Cache support to MobileWebApp sample. (issue1422815)

2011-04-29 Thread rchandia
Reviewers: cramsdale, jlabanca, pdr, Description: Adds HTML5 App Cache support to MobileWebApp sample. Uses a custom linker to figure out which files were generated by GWTC. Moved source to src/main and placed linker into src/dev. Please review this at

[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-04-29 Thread tobyr
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

[gwt-contrib] Pass the root bean class to constraint violation from validateValue (issue1428806)

2011-04-29 Thread nchalko
Reviewers: rchandia, Description: Pass the root bean class to constraint violation from validateValue [JSR 303 TCK Result] 124 of 257 (48.25%) Pass with 8 Failures and 7 Errors. Please review this at http://gwt-code-reviews.appspot.com/1428806/ Affected files: M

[gwt-contrib] Re: Pass the root bean class to constraint violation from validateValue (issue1428806)

2011-04-29 Thread rchandia
LGTM. With nit. http://gwt-code-reviews.appspot.com/1428806/diff/1/user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java File user/test/org/hibernate/jsr303/tck/tests/validation/graphnavigation/TckTestValidatorFactory.java (right):

[gwt-contrib] Fix Attachable for those poor fellows who don't have the bliss of SafeHtml enabled (yet). (issue1426808)

2011-04-29 Thread rdcastro
Reviewers: rjrjr, Description: Fix Attachable for those poor fellows who don't have the bliss of SafeHtml enabled (yet). Please review this at http://gwt-code-reviews.appspot.com/1426808/ Affected files: M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java Index:

[gwt-contrib] Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-04-29 Thread hermes
Reviewers: rdcastro, rjrjr, Description: Introducing FieldTypeWriter, an enum that identifies field writers and defines precedences useful for disambiguation when sorting builders in the Widgets ctor. Please review this at http://gwt-code-reviews.appspot.com/1428807/ Affected files: M

[gwt-contrib] [google-web-toolkit] r10116 committed - Pass the root bean class to constraint violation from validateValue...

2011-04-29 Thread codesite-noreply
Revision: 10116 Author: ncha...@google.com Date: Fri Apr 29 13:15:53 2011 Log: Pass the root bean class to constraint violation from validateValue [JSR 303 TCK Result] 124 of 257 (48.25%) Pass with 8 Failures and 7 Errors. Review at http://gwt-code-reviews.appspot.com/1428806