[gwt-contrib] Fixes and cleanup to expenses sample pom.xml (issue1534805)

2011-08-31 Thread rchandia
Reviewers: rjrjr, drfibonacci, Description: Fixes and cleanup to expenses sample pom.xml - Bumps GWT version - RF verification Please review this at http://gwt-code-reviews.appspot.com/1534805/ Affected files: M samples/expenses/pom.xml --

[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

2011-08-31 Thread jlabanca
committed as r10597 http://gwt-code-reviews.appspot.com/1533804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes and cleanup to expenses sample pom.xml (issue1534805)

2011-08-31 Thread drfibonacci
LGTM http://gwt-code-reviews.appspot.com/1534805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10598 committed - Fixes and cleanup to expenses sample pom.xml...

2011-08-31 Thread codesite-noreply
Revision: 10598 Author: rchan...@google.com Date: Wed Aug 31 05:45:29 2011 Log: Fixes and cleanup to expenses sample pom.xml - Bumps GWT version - RF verification Review at http://gwt-code-reviews.appspot.com/1534805 http://code.google.com/p/google-web-toolkit/source/detail?r=10598

[gwt-contrib] [google-web-toolkit] r10599 committed - Cherry picking r10598 into releases/2.4

2011-08-31 Thread codesite-noreply
Revision: 10599 Author: rchan...@google.com Date: Wed Aug 31 06:27:18 2011 Log: Cherry picking r10598 into releases/2.4 http://code.google.com/p/google-web-toolkit/source/detail?r=10599 Modified: /releases/2.4/samples/expenses/pom.xml === ---

[gwt-contrib] Re: Fixes DynaTableRF interface validation, and silences quirks mode warning. (issue1534807)

2011-08-31 Thread rjrjr
On 2011/08/31 18:52:12, rjrjr wrote: Ready for review. Note that Rietveld ignores the binary file I'm adding: samples/dynatablerf/apt/requestfactory-apt.jar http://gwt-code-reviews.appspot.com/1534807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes DynaTableRF interface validation, and silences quirks mode warning. (issue1534807)

2011-08-31 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1534807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10600 committed - Fix a bug where isUnhover is fired with the opposite value....

2011-08-31 Thread codesite-noreply
Revision: 10600 Author: pengzhu...@google.com Date: Wed Aug 31 08:59:55 2011 Log: Fix a bug where isUnhover is fired with the opposite value. Review at http://gwt-code-reviews.appspot.com/1535804 Review by: jlaba...@google.com

Re: [gwt-contrib] maven source jars

2011-08-31 Thread Stephen Haberman
so renaming it without regenerating or stripping the JarIndex (META-INF/INDEX.LIST) generates spurious exceptions in DevMode So that's what been causing that for me--I never would have thought renaming the jar file would be a problem. Thanks for pointing that out! - Stephen --

[gwt-contrib] [google-web-toolkit] r10601 committed - Fixes DynaTableRF interface validation, and silences quirks mode warni...

2011-08-31 Thread codesite-noreply
Revision: 10601 Author: rj...@google.com Date: Wed Aug 31 09:17:19 2011 Log: Fixes DynaTableRF interface validation, and silences quirks mode warning. Review at http://gwt-code-reviews.appspot.com/1534807 Review by: rchan...@google.com

[gwt-contrib] Fixes for MobileWebApp pom.xml (issue1520809)

2011-08-31 Thread rchandia
Reviewers: drfibonacci, rjrjr, Description: Fixes for MobileWebApp pom.xml - Fix RF validation - Bumps GAE version - Minor cleanup Please review this at http://gwt-code-reviews.appspot.com/1520809/ Affected files: M samples/mobilewebapp/pom.xml Index: samples/mobilewebapp/pom.xml

[gwt-contrib] Re: Fixes for MobileWebApp pom.xml (issue1520809)

2011-08-31 Thread drfibonacci
LGTM http://gwt-code-reviews.appspot.com/1520809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10602 committed - Integrates r10598, DynaTableRF fixes

2011-08-31 Thread codesite-noreply
Revision: 10602 Author: rj...@google.com Date: Wed Aug 31 09:36:53 2011 Log: Integrates r10598, DynaTableRF fixes http://code.google.com/p/google-web-toolkit/source/detail?r=10602 Added: /releases/2.4/samples/dynatablerf/apt

[gwt-contrib] Re: Fixes for MobileWebApp pom.xml (issue1520809)

2011-08-31 Thread Ray Ryan
LGTM On Wed, Aug 31, 2011 at 1:18 PM, drfibona...@google.com wrote: LGTM http://gwt-code-reviews.**appspot.com/1520809/http://gwt-code-reviews.appspot.com/1520809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10603 committed - Fixes for MobileWebApp pom.xml...

2011-08-31 Thread codesite-noreply
Revision: 10603 Author: rchan...@google.com Date: Wed Aug 31 10:35:46 2011 Log: Fixes for MobileWebApp pom.xml - Fix exec-maven-plugin configuration - Bumps GAE version - Minor cleanup Review at http://gwt-code-reviews.appspot.com/1520809

[gwt-contrib] Scripts and configuration to upload GWT bits to Maven repos (issue1520810)

2011-08-31 Thread rchandia
Reviewers: rjrjr, drfibonacci, Description: Scripts and configuration to upload GWT bits to Maven repos - Removed now redundant maven_script.sh Please review this at http://gwt-code-reviews.appspot.com/1520810/ Affected files: A maven/poms/appengine/appengine-api-1.0-sdk/pom-template.xml

[gwt-contrib] [google-web-toolkit] r10604 committed - Cherry picking r10603 into releases/2.4

2011-08-31 Thread codesite-noreply
Revision: 10604 Author: rchan...@google.com Date: Wed Aug 31 10:56:17 2011 Log: Cherry picking r10603 into releases/2.4 http://code.google.com/p/google-web-toolkit/source/detail?r=10604 Modified: /releases/2.4/samples/mobilewebapp/pom.xml === ---

[gwt-contrib] Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)

2011-08-31 Thread rjrjr
Reviewers: knorton, Description: Update the missing plugin page to stop taunting Safari 5.1 users, and suggest they try out OmniWeb. Review by: knor...@google.com Please review this at http://gwt-code-reviews.appspot.com/1536803/ Affected files: M

[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)

2011-08-31 Thread rjrjr
http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)

2011-08-31 Thread rjrjr
http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-31 Thread zhuyi
http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-31 Thread zhuyi
On 2011/09/01 00:10:12, zhuyi wrote: Hi Stephen, I've integrated your changes, also synced the changes. Sorry for the delay. Could you please review it? Thanks. Yi http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-31 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml File user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml (right):

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-08-31 Thread stephen . haberman
I've integrated your changes, also synced the changes. Thanks! Could you please review it? Sure. I understand a bit more about how it works now. Previously, the server-side ignored all final fields. You understandably had to change that, but since the server-side doesn't have access to