[gwt-contrib] Re: Less Name Mangling (issue1542804)

2011-09-12 Thread stephen . haberman
Okay, this is ready for review. http://gwt-code-reviews.appspot.com/1542804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on RequestFactoryInterfaceValidation in google-web-toolkit

2011-09-12 Thread codesite-noreply
Comment by mauro.be...@gmail.com: IDE configuration for Intellij IDEA: http://goo.gl/6P6dT For more information: http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryInterfaceValidation -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] dependencies/qualified refs

2011-09-12 Thread Stephen Haberman
The simple and qualified references answer the question What references do I depend on to correctly parse and resolve the source code? Api refs answer the question What program elements do I need to construct a TypeOracle representation of this class? Ah, okay, that makes sense. I found

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread rjrjr
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread rchandia
LGTM. Once the ScriptAssert issue gets resolved. On 2011/09/12 16:27:34, rjrjr wrote: http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread Ray Ryan
It's resolved if Nick gives his LGTM On Mon, Sep 12, 2011 at 9:34 AM, rchan...@google.com wrote: LGTM. Once the ScriptAssert issue gets resolved. On 2011/09/12 16:27:34, rjrjr wrote: http://gwt-code-reviews.**appspot.com/1537805/http://gwt-code-reviews.appspot.com/1537805/ --

[gwt-contrib] Re: Support older bash interpreter in maven upload script (issue1537806)

2011-09-12 Thread rjrjr
LGTM Works on my Mac, thanks for the fixes. One echo request. http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh File maven/lib-gwt.sh (right): http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh#newcode101 maven/lib-gwt.sh:101: # once we rename the jar files

Re: [gwt-contrib] dependencies/qualified refs

2011-09-12 Thread Stephen Haberman
The simple and qualified references answer the question What references do I depend on to correctly parse and resolve the source code? Okay, so I do have a question about these. Debugging the ecj behavior, I was looking at the output for some class in the c.g.g.u.client.rpc.core (abbreviated

[gwt-contrib] Re: Support older bash interpreter in maven upload script (issue1537806)

2011-09-12 Thread rchandia
http://gwt-code-reviews.appspot.com/1537806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support older bash interpreter in maven upload script (issue1537806)

2011-09-12 Thread rchandia
http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh File maven/lib-gwt.sh (right): http://gwt-code-reviews.appspot.com/1537806/diff/1/maven/lib-gwt.sh#newcode101 maven/lib-gwt.sh:101: # once we rename the jar files for Maven On 2011/09/12 16:43:55, rjrjr wrote: echo Removing

[gwt-contrib] [google-web-toolkit] r10639 committed - Support older bash interpreter in maven upload script...

2011-09-12 Thread codesite-noreply
Revision: 10639 Author: rchan...@google.com Date: Mon Sep 12 07:14:08 2011 Log: Support older bash interpreter in maven upload script Review at http://gwt-code-reviews.appspot.com/1537806 http://code.google.com/p/google-web-toolkit/source/detail?r=10639 Modified:

[gwt-contrib] Re: Support older bash interpreter in maven upload script (issue1537806)

2011-09-12 Thread rchandia
Submitted as r10639 http://gwt-code-reviews.appspot.com/1537806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: ui:with to set property values (issue1524803)

2011-09-12 Thread Rafael Castro
On Wed, Sep 7, 2011 at 9:15 AM, jus...@jhickman.com wrote: There's a part of the generated code that calls all build_*() methods. Can you take a look and see in which order they are being called? If you change your test template (for instance, make test1 depend on test3 instead), does it

[gwt-contrib] [google-web-toolkit] r10640 committed - Edited wiki page WorkingWithMaven through web user interface.

2011-09-12 Thread codesite-noreply
Revision: 10640 Author: drfibona...@google.com Date: Mon Sep 12 11:34:00 2011 Log: Edited wiki page WorkingWithMaven through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10640 Modified: /wiki/WorkingWithMaven.wiki

[gwt-contrib] Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)

2011-09-12 Thread rjrjr
Reviewers: rchandia, Description: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. Please review this at http://gwt-code-reviews.appspot.com/1543803/ Affected files: M samples/dynatablerf/pom.xml A samples/dynatablerf/src/main/resources/log4j.properties

[gwt-contrib] Re: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)

2011-09-12 Thread rjrjr
DTRF runs without warnings. mobilewebapp is down to the following, which is an improvement at least. [WARNING] Don't declare gwt-dev as a project dependency. This may introduce complex dependency conflicts [INFO] create exploded Jetty webapp in

[gwt-contrib] Re: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)

2011-09-12 Thread rjrjr
And, ready for review please. Or advice on stomping the last errors. The org.mortbay.log.StdErrLog one is kind of aggravating, since it seems like it's simply misrouted, should be an [INFO] http://gwt-code-reviews.appspot.com/1543803/ --

[gwt-contrib] Re: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. (issue1543803)

2011-09-12 Thread rchandia
LGTM. The gwt-dev one is hard to avoid as long as we compile the linker alongside the rest of the app. On 2011/09/12 18:41:47, rjrjr wrote: And, ready for review please. Or advice on stomping the last errors. The org.mortbay.log.StdErrLog one is kind of aggravating, since it seems like

[gwt-contrib] [google-web-toolkit] r10641 committed - Fixes logging and character set warnings for dynatablerf and mobileweb...

2011-09-12 Thread codesite-noreply
Revision: 10641 Author: rj...@google.com Date: Mon Sep 12 09:46:24 2011 Log: Fixes logging and character set warnings for dynatablerf and mobilewebapp samples. Review at http://gwt-code-reviews.appspot.com/1543803 Review by: rchan...@google.com

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread nchalko
http://gwt-code-reviews.appspot.com/1537805/diff/5004/samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml File samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml (right):

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread nchalko
LGTM http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] When -XdisableClassMetadata is used, Class.getName() can return Class$SseedNumber as a class n... (issue1540804)

2011-09-12 Thread cromwellian
Reviewers: rjrjr, Description: When -XdisableClassMetadata is used, Class.getName() can return Class$SseedNumber as a class name. However, there are other modes where it can return Class$obfuscated function name. In some rare cases, these two could collide of if an obfuscated name of a class

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread rjrjr
http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: When -XdisableClassMetadata is used, Class.getName() can return Class$SseedNumber as a class n... (issue1540804)

2011-09-12 Thread Ray Ryan
LGTM Nice catch. Is there really no test to extend for this? :-( On Mon, Sep 12, 2011 at 5:39 PM, cromwell...@google.com wrote: Reviewers: rjrjr, Description: When -XdisableClassMetadata is used, Class.getName() can return Class$SseedNumber as a class name. However, there are other modes

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread rjrjr
Submitting http://gwt-code-reviews.appspot.com/1537805/diff/5004/samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml File samples/validation/src/main/java/com/google/gwt/sample/validation/Validation.gwt.xml (right):

[gwt-contrib] Re: Converts the validation sample to build with maven. (issue1537805)

2011-09-12 Thread nchalko
LGTM http://gwt-code-reviews.appspot.com/1537805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Makes the @GwtTransient mechanism work for any annotation with that (issue1544803)

2011-09-12 Thread rjrjr
Reviewers: cromwellian, Description: Makes the @GwtTransient mechanism work for any annotation with that simple name. Please review this at http://gwt-code-reviews.appspot.com/1544803/ Affected files: M user/src/com/google/gwt/user/client/rpc/GwtTransient.java M