LGTM
Oops. Thanks Nick. I'll need to remember to put this on the 2.4 branch.
On Sep 13, 2011 7:27 PM, ncha...@google.com wrote:
Reviewers: rjrjr,
Description:
Update the checkstule path for validation sample
Fix the @NotSupported count
Please review this at
Revision: 10646
Author: gwt.mirror...@gmail.com
Date: Wed Sep 14 06:33:50 2011
Log: Update the checkstule path for validation sample
Fix the @NotSupported count
Review at http://gwt-code-reviews.appspot.com/1547803
Review by: rj...@google.com
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Introduces BrowserEvents string constants
Please review this at http://gwt-code-reviews.appspot.com/1550803/
Affected files:
M user/src/com/google/gwt/cell/client/AbstractCell.java
M user/src/com/google/gwt/cell/client/AbstractInputCell.java
M
http://gwt-code-reviews.appspot.com/1380807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ray, John and others:
I and Stephen have been working on this for a while to make the option
of serializing final fields in RPC be a non-static variable to eliminate
flakiness, and pass this option to server side by serialization policy
file. Please let us know if the change is in good shape and
Reviewers: rjrjr,
Description:
Fixes fake even dispatch in UiRendererEventsTest for IE8 and less
Please review this at http://gwt-code-reviews.appspot.com/1550804/
Affected files:
M user/test/com/google/gwt/uibinder/test/client/UiRendererEventsTest.java
Index:
On 2011/09/14 18:58:04, jhumphries wrote:
LGTM again
http://gwt-code-reviews.appspot.com/1499811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/09/14 18:58:04, jhumphries wrote:
LGTM again
http://gwt-code-reviews.appspot.com/1499811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Seems reasonable, except that I lack context and don't know what you're
actually trying to do. Is there a design doc somewhere?
http://gwt-code-reviews.appspot.com/1499811/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Sweet. Thanks for the fix.
http://gwt-code-reviews.appspot.com/1550804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10647
Author: rj...@google.com
Date: Wed Sep 14 14:31:53 2011
Log: Edited wiki page RequestFactoryInterfaceValidation through web
user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=10647
Modified:
/wiki/RequestFactoryInterfaceValidation.wiki
Revision: 10648
Author: rchan...@google.com
Date: Wed Sep 14 11:48:51 2011
Log: Fixes fake even dispatch in UiRendererEventsTest for IE8 and less
Review at http://gwt-code-reviews.appspot.com/1550804
Review by: rj...@google.com
Reviewers: drfibonacci,
Description:
Do RF validation via APT instead of command line.
Please review this at http://gwt-code-reviews.appspot.com/1547804/
Affected files:
M samples/dynatablerf/pom.xml
Index: samples/dynatablerf/pom.xml
Rajeev, this changes the DynaTableRf sample to use APT for rf validation
instead of the command line tool.
* mvn gwt:run works just fine at the command line
* it imports into indigo (required the lifecycle mapping brain damage)
* m2e can launch it as a maven goal
* gpe run as web app works iff I
More: if this solves whatever problem it is you're trying to solve,
we'll need to make the same change to mobilewebapp, and update the
pom.xml recipe on that wiki page.
@drfibonacci, notice that I had to make make gwt-servlet into a real
dependency instead of just a runtime one. Is that okay?
RayC, John is on vacation. Can you review? Please keep a good eye out
for typos.
http://gwt-code-reviews.appspot.com/1550803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/09/14 21:19:55, rjrjr wrote:
LGTM
Sweet. Thanks for the fix.
You are welcome. Submitted as r10648.
http://gwt-code-reviews.appspot.com/1550804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
18 matches
Mail list logo
