[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)

2011-09-19 Thread jlabanca
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java File user/src/com/google/gwt/dom/client/BrowserEvents.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java#newcode39

[gwt-contrib] IE + SSL + Image.setURL throws an Operation Exception at runtime

2011-09-19 Thread DaveC
I think this maybe be a bug with GWT (but I'm not sure). I'm running my app under https/ssl, in IE (7 8) I get an Operation Exception (Network Error) if I set a previously created Image widget's url to an unsecured url (which causes IE to popup a dialog asking the user for permission). The

[gwt-contrib] Re: Fix javadoc for new timezone-aware constructors of DateCell. (issue1545803)

2011-09-19 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1545803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: During row mouseout events, only consider it as row unhovering if the (issue1546803)

2011-09-19 Thread jlabanca
http://gwt-code-reviews.appspot.com/1546803/diff/1/user/src/com/google/gwt/user/cellview/client/RowHoverEvent.java File user/src/com/google/gwt/user/cellview/client/RowHoverEvent.java (right):

[gwt-contrib] Allow DateBox to fire events with null date values for invalid and empty input (issue1552803)

2011-09-19 Thread justinfagnani
Reviewers: rjrjr, Description: Allow DateBox to fire events with null date values for invalid and empty input strings. Please review this at http://gwt-code-reviews.appspot.com/1552803/ Affected files: M user/src/com/google/gwt/user/datepicker/client/DateBox.java Index:

[gwt-contrib] Re: Allow DateBox to fire events with null date values for invalid and empty input (issue1552803)

2011-09-19 Thread justinfagnani
http://gwt-code-reviews.appspot.com/1552803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)

2011-09-19 Thread t . broyer
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java File user/src/com/google/gwt/dom/client/BrowserEvents.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java#newcode39

[gwt-contrib] Re: Enable FF6 Plugin in MissingPlugin Page. (issue1551803)

2011-09-19 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1551803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixes some errors in the eclipse readme, and fixes some marker files. (issue1553803)

2011-09-19 Thread rjrjr
Reviewers: rchandia, Description: Fixes some errors in the eclipse readme, and fixes some marker files. Please review this at http://gwt-code-reviews.appspot.com/1553803/ Affected files: M eclipse/README.txt A samples/hello/war/WEB-INF/classes/marker Index: eclipse/README.txt

[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)

2011-09-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)

2011-09-19 Thread rjrjr
PTAL http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java File user/src/com/google/gwt/dom/client/Document.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode18

[gwt-contrib] Re: Introduces BrowserEvents string constants (issue1550803)

2011-09-19 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes some errors in the eclipse readme, and fixes some marker files. (issue1553803)

2011-09-19 Thread rchandia
LGTM. W/nits http://gwt-code-reviews.appspot.com/1553803/diff/1/eclipse/README.txt File eclipse/README.txt (right): http://gwt-code-reviews.appspot.com/1553803/diff/1/eclipse/README.txt#newcode115 eclipse/README.txt:115: Project-Properties-Java Compiler-AnnotationProcessor-Factory Path Indent

[gwt-contrib] Re: Allow DateBox to fire events with null date values for invalid and empty input (issue1552803)

2011-09-19 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1552803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10656 committed - Fixes some errors in the eclipse readme, and fixes some marker files....

2011-09-19 Thread codesite-noreply
Revision: 10656 Author: rj...@google.com Date: Mon Sep 19 14:21:25 2011 Log: Fixes some errors in the eclipse readme, and fixes some marker files. Review at http://gwt-code-reviews.appspot.com/1553803 Review by: rchan...@google.com

[gwt-contrib] [google-web-toolkit] r10657 committed - Edited wiki page BeanValidation through web user interface.

2011-09-19 Thread codesite-noreply
Revision: 10657 Author: ncha...@google.com Date: Mon Sep 19 20:31:06 2011 Log: Edited wiki page BeanValidation through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10657 Modified: /wiki/BeanValidation.wiki ===

[gwt-contrib] Re: Less Name Mangling (issue1542804)

2011-09-19 Thread stephen . haberman
Oh jeez. Reitveld just dropped a huge comment I had due to an invalid XSRF token. Let's try again. Scala puts $ in class names, e.g. Foo$.class for objects, so scalagwt would have classes like Foo$$Bar or Foo$$anon$2 that messed up the usual Foo$Bar - Foo.Bar source name heuristic. This led to

[gwt-contrib] Re: Less Name Mangling (issue1542804)

2011-09-19 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1542804/diff/5001/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right):