[gwt-contrib] Re: Add a support for header builder to return row index for multi-row (issue1555803)

2011-09-21 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1555803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10662 committed - Add a support for header builder to return row index for multi-row...

2011-09-21 Thread codesite-noreply
Revision: 10662 Author: pengzhu...@google.com Date: Wed Sep 21 06:39:41 2011 Log: Add a support for header builder to return row index for multi-row header/footer. Review at http://gwt-code-reviews.appspot.com/1555803 Review by: jlaba...@google.com

[gwt-contrib] Re: ui:with to set property values (issue1524803)

2011-09-21 Thread Rafael Castro
Exactly, your diagnosis matches my expectation. The thing is we do the precedence detection when first declaring the widget, making sure that its at least (parentWidget.getPrecedence() + 1). And you're right that we don't update it when we see a reference. I think that to make your scheme

[gwt-contrib] Re: Makes sure all attributes from the PotentialElement can be inherited (issue1556803)

2011-09-21 Thread rdcastro
http://gwt-code-reviews.appspot.com/1556803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Makes sure all attributes from the PotentialElement can be inherited (issue1556803)

2011-09-21 Thread rjrjr
LGTM with one typo fixed http://gwt-code-reviews.appspot.com/1556803/diff/2002/user/src/com/google/gwt/user/client/ui/PotentialElement.java File user/src/com/google/gwt/user/client/ui/PotentialElement.java (right):

[gwt-contrib] [google-web-toolkit] r10663 committed - Enable FF6 Plugin in MissingPlugin Page....

2011-09-21 Thread codesite-noreply
Revision: 10663 Author: acle...@google.com Date: Wed Sep 21 16:16:57 2011 Log: Enable FF6 Plugin in MissingPlugin Page. Review at http://gwt-code-reviews.appspot.com/1551803 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10663 Modified:

[gwt-contrib] Re: Comment on RequestFactoryInterfaceValidation in google-web-toolkit

2011-09-21 Thread codesite-noreply
Comment by rmattis...@gmail.com: Unable to initialize a JSR 303 Bean Validator javax.validation.ValidationException: Unable to find a default provider ??? For more information: http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryInterfaceValidation --

[gwt-contrib] Re: Comment on RequestFactoryInterfaceValidation in google-web-toolkit

2011-09-21 Thread codesite-noreply
Comment by larse...@gmail.com: If you don't include a jsr-303 validator, then you'll get this WARNING. If you want it to go away, you can include the hibernate validator of versions greater than or equal to 4. I'm unaware of any other 303 bean validators out there. Or you could just