Re: [gwt-contrib] Patch for RichTextEditor

2012-10-12 Thread Stephen Haberman
It looks like he posted a complete patch almost three years ago. What do we need to do to get this into trunk? https://developers.google.com/web-toolkit/makinggwtbetter#contributingcode Generally, sign a CLA, and upload it to Rietveld; not sure who to pick as the reviewer, I'll volunteer

[gwt-contrib] Re: Be stricter about quoting JSON strings in AutoBeans. In particular, (issue1853803)

2012-10-12 Thread t . broyer
Should HTML-specific escaping be done on top of the value produced by AutoBeans? Do we really want to pay the tax (each one of =' is replaced by 6 chars!) for each AutoBean-based exchanged over the wire (for example, RequestFactory uses Base64-encoding for its stableId and version, which makes

[gwt-contrib] Re: Be stricter about quoting JSON strings in AutoBeans. In particular, (issue1853803)

2012-10-12 Thread cromwellian
One option is to have an extra method like encodeForHtmlContext() where you only pay the tax in that circumstance. http://gwt-code-reviews.appspot.com/1853803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors