[gwt-contrib] Re: DateBox (DatePicker) still allows user to choose disabled dates with mouse click (issue1885803)

2013-01-24 Thread t . broyer
Can you please make your patch from trunk/ rather than trunk/user/src/com/google/gwt/user/datepicker/client/ ? That said, there are other implications than just selecting from the calendar view: - what if I setValue() with a disabled date? (I mean, what should be the expected behavior) - what

[gwt-contrib] Change in gwt[master]: Make AnimationScheduler configurable and change defaults.

2013-01-24 Thread Ray Cromwell
Ray Cromwell has posted comments on this change. Change subject: Make AnimationScheduler configurable and change defaults. .. Patch Set 3: // TODO: register a Disposable when unloadModule patch lands -- To view, visit

[gwt-contrib] Re: Support withCredentials attribute for XHR requests (Chrome 3+, Firefox 3.5+, Opera12+, Safari 4+... (issue1879804)

2013-01-24 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1879804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add experimental GWT.unloadModule() function. (issue1827804)

2013-01-24 Thread t . broyer
LGTM. Nothing controversial I believe. This is a pretty big change though, so maybe an additional pair of eyes would be better (but maybe you also have an internal review ongoing?) http://gwt-code-reviews.appspot.com/1827804/diff/1/user/src/com/google/gwt/core/client/impl/Impl.java File

[gwt-contrib] DateBox (DatePicker) still allows user to choose disabled dates with mouse click (issue1885803)

2013-01-24 Thread cswillseph
Reviewers: , Description: I am submitting a patch to issue 7876 in the GWT issue tracker (http://code.google.com/p/google-web-toolkit/issues/detail?id=7876) as part of a university software engineering project. I found that each datepicker cell has a boolean enabled value, and the method

Re: [gwt-contrib] source maps in chrome

2013-01-24 Thread Brian Slesinsky
I've tried it recently with Chrome 25. You've checked the source maps on checkbox and reloaded the page? On Tuesday, January 22, 2013 1:08:41 PM UTC-8, Daniel Kurka wrote: I can`t seem to get source maps working with Chrome 24. Is it just me or is there still something off? On Friday,