[gwt-contrib] Re: [Code Review] Small Test Framework For JJS Optimizers

2008-10-06 Thread Mike Aizatsky
Scott, - Could briefly summarize the motivation for the suite()/JJSOptimizerTestDecator design? This way the module will be compiled only once. Unfortunately JavaToJavaScriptCompiler doesn't have any easily extract compiling pass and I didn't want to seriously refactor it. -

[gwt-contrib] Re: Patch: Build File Fix

2008-10-06 Thread Mike Aizatsky
. General concept is fine, of course, but can we make those changes? On Fri, Oct 3, 2008 at 8:28 PM, Scott Blum [EMAIL PROTECTED] wrote: Freeland, it's all you. :) On Fri, Oct 3, 2008 at 8:23 PM, Mike Aizatsky [EMAIL PROTECTED] wrote: Hi! I've fixed build file to support working in non-svn

[gwt-contrib] Re: [Code Review] Small Test Framework For JJS Optimizers

2008-10-06 Thread Mike Aizatsky
Scott, - Could briefly summarize the motivation for the suite()/JJSOptimizerTestDecator design? This way the module will be compiled only once. Unfortunately JavaToJavaScriptCompiler doesn't have any easily extract compiling pass and I didn't want to seriously refactor it. I'm not sure

[gwt-contrib] Re: [Code Review] Small Test Framework For JJS Optimizers

2008-10-06 Thread Mike Aizatsky
Gotcha. But if you don't compile multiple times, how do you prevent optimizations that occur in one test method from impacting ones that occur in another test method? I can't. I do this by limiting the scope optimization should work on (see MethodInlineTest)... By the way, I've already got

[gwt-contrib] Re: Re: [Code Review] Small Test Framework For JJS Optimizers

2008-12-22 Thread mike . aizatsky
rather skip optimizations during initial construction in order to surgically call specific optimizers. Thoughts? On Tue, Dec 16, 2008 at 9:58 PM, Mike Aizatsky mike.aizat...@gmail.com wrote: Scott, I'm sorry I've disappeared, but I had really busy couple of months. I have resurrected

[gwt-contrib] Fwd: Flow analysis framework definition and solver.

2009-12-01 Thread Mike Aizatsky
Forwarding since I wasn't member of the group. -- Forwarded message -- From: mike.aizat...@gmail.com Date: Tue, Dec 1, 2009 at 1:52 PM Subject: Re: Flow analysis framework definition and solver. To: sp...@google.com, google-web-toolkit-contributors@googlegroups.com,

[gwt-contrib] Re: Flow analysis framework definition and solver.

2009-12-01 Thread Mike Aizatsky
Well, it would be sitting in svn and not being tested in any way except that it compiles. If you want to commit the pieces somewhere, why don't we make an svn branch? I don't think svn branch will help much. It will only add headaches. What do you say if I would merge all LGTM'ed changes

[gwt-contrib] Control flow graph abstraction builder for CFG optimizations.

2009-12-04 Thread mike . aizatsky
Reviewers: Lex, Message: Lex, This is the second installment. Take a look. Description: Control flow graph abstraction builder for CFG optimizations. Doesn't include actual optimizations. Please review this at http://gwt-code-reviews.appspot.com/117805 Affected files: M

[gwt-contrib] Re: Control flow graph abstraction builder for CFG optimizations.

2009-12-15 Thread mike . aizatsky
Lex, Next patch will contains 3 optimizations. Promise! :) http://gwt-code-reviews.appspot.com/117805/diff/2047/1046 File dev/core/src/com/google/gwt/dev/util/Either.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1046#newcode76 Line 76: return true; On 2009/12/15 23:00:37,

[gwt-contrib] Re: Control flow graph abstraction builder for CFG optimizations.

2009-12-15 Thread mike . aizatsky
Merged into http://gwt-code-reviews.appspot.com/126803 http://gwt-code-reviews.appspot.com/117805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Unreachable analysis/optimization.

2010-01-19 Thread mike . aizatsky
Reviewers: Lex, Message: Requesting review Description: Unreachable analysis/optimization. Determines CFG nodes which are not reachable, and deletes them from source tree if possible. Please review this at http://gwt-code-reviews.appspot.com/130814 Affected files: A

[gwt-contrib] Copy propagation analysis/optimization.

2010-01-19 Thread mike . aizatsky
Reviewers: Lex, Message: Requesting review. Description: Copy propagation analysis/optimization. Detects when variable is the copy of another and uses older var instead. Please review this at http://gwt-code-reviews.appspot.com/132814 Affected files: A

[gwt-contrib] Analysis framework update driven by compile time optimization.

2010-01-19 Thread mike . aizatsky
Reviewers: Lex, Message: Requesting review. Description: Analysis framework update driven by compile time optimization. Please review this at http://gwt-code-reviews.appspot.com/132813 Affected files: M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/Analysis.java M

[gwt-contrib] SameParameterValueOptimizer should ignore methods called from native code.

2010-02-12 Thread mike . aizatsky
Reviewers: Lex, Message: Lex, Please review. Description: SameParameterValueOptimizer should ignore methods called from native code. Please review this at http://gwt-code-reviews.appspot.com/141812 Affected files: M

[gwt-contrib] Gflow framework passes all smoke tests

2010-02-26 Thread mike . aizatsky
Reviewers: Lex, Message: Lex, these changes make gflow framework to pass all smoke tests. Please take a look. Please review this at http://gwt-code-reviews.appspot.com/153807 Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JIfStatement.java M

[gwt-contrib] Re: Gflow framework passes all smoke tests

2010-02-26 Thread mike . aizatsky
Lex, All done. All tests pass. PTAL. http://gwt-code-reviews.appspot.com/153807/diff/1/9 File dev/core/src/com/google/gwt/dev/jjs/ast/JReferenceType.java (right): http://gwt-code-reviews.appspot.com/153807/diff/1/9#newcode28 Line 28: public static JType dereference(JType type) { On 2010/02/26

[gwt-contrib] Re: Gflow framework passes all smoke tests

2010-03-02 Thread mike . aizatsky
http://gwt-code-reviews.appspot.com/153807/diff/1002/82 File dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java (right): http://gwt-code-reviews.appspot.com/153807/diff/1002/82#newcode736 Line 736: } else if (typeOracle.canTriviallyCast(catchType, exceptionType)) { According to

[gwt-contrib] Fixing StackOverflow

2010-03-02 Thread mike . aizatsky
Reviewers: Lex, Message: Lex, This adds some debugging facilities and fixes recursion problems in copy propagation analysis. Please take a look. Please review this at http://gwt-code-reviews.appspot.com/154811 Affected files: M

[gwt-contrib] gflow nested switch statements

2010-03-11 Thread mike . aizatsky
Reviewers: Lex, Description: Fixing gflow nested switch CFG generation Added couple of tostrings to aid in debugging. Please review this at http://gwt-code-reviews.appspot.com/180801 Affected files: dev/core/src/com/google/gwt/dev/jjs/impl/gflow/AnalysisSolver.java

[gwt-contrib] Re: Removes unnecessary uses of a JProgram instance where it's really not needed. (issue295802)

2010-04-02 Thread mike . aizatsky
LGTM http://gwt-code-reviews.appspot.com/295802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using remove me as the subject.