[gwt-contrib] Re: Design Time Access to UiBinder Model

2011-10-03 Thread Konstantin Scheglov
Basically these hooks allow you get notification about bean object creation and provide result for @UiField(provided=true) and @UiFactory. That's all. See implementation here:

[gwt-contrib] Re: [GWT Designer] Use per ClassLoader ModuleDef caching (issue1274801)

2011-01-11 Thread Konstantin . Scheglov
On 2011/01/11 16:21:50, scottb wrote: Generally, can you justify this scheme? I read the article, but I still don't understand the advantage of this approach over say, MapClassLoader, ? where the key is weak. Problem happens when you have reference from value to key. For example, if

[gwt-contrib] Re: [GWT Designer] Don't cache rebind results while design time (issue1275801)

2011-01-11 Thread Konstantin . Scheglov
On 2011/01/11 18:00:42, jbrosenberg wrote: I'm not sure I understand the larger picture, but I think there are some issues with this approach. Perhaps we can connect up to discuss furtherHere are some of the main points to consider: 1. StandardRebindOracle should not know anything

[gwt-contrib] UiBinder. Support for TreeItems. (issue1233803)

2011-01-04 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: For Java UI the GWT Designer support dropping TreeItem on Tree and other TreeItem. We need same feature for UiBinder too. This patch adds parsers for Tree and TreeItem which support this feature. Please review this at

Re: [gwt-contrib] Re: r9277 committed - Removing reference to designTime.getProvidedField()

2010-11-27 Thread Konstantin Scheglov
://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Konstantin Scheglov, Google, Inc. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tweak for @UiChild javadoc (issue1132801)

2010-11-21 Thread Konstantin . Scheglov
Reviewers: rjrjr, rice, Description: JavaDoc does not show example. http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/uibinder/client/UiChild.html Changes in this (trivial) patch. 1. Left angle bracket should be quoted. 2. Fix for indentation. Please review this at

[gwt-contrib] Re: UiBinder. Design time tweaks for @UiField(provided) and @UiFactory (issue1077802)

2010-11-09 Thread Konstantin . Scheglov
http://gwt-code-reviews.appspot.com/1077802/diff/1/3 File user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java (right): http://gwt-code-reviews.appspot.com/1077802/diff/1/3#newcode52 user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java:52: w.write( void handle(String

[gwt-contrib] UiBinder. Using negative values in LayoutPanel. (issue1094801)

2010-11-09 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: http://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/9832f30485ce48e2 This patch contains: 1. tweak for LengthAttributeParser to support +/- before value; 2. check for negative width/height in LayoutPanelParser; 3. tests for negative

[gwt-contrib] UiBinder. Design time tweaks for @UiField(provided) and @UiFactory (issue1077802)

2010-11-04 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: We need to provide at least some support for @UiField(provided) and @UiFactory in GWT Designer. At design time we pass null as owner, so we need to use special design time hooks to create instances of widgets. Please review this at

[gwt-contrib] Use @UiChild and @UiConstructor (issue865801)

2010-09-12 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: These annotations allow us use HorizontalSplitPanel, VerticalSplitPanel and NamedFrame in UiBinder. Please review this at http://gwt-code-reviews.appspot.com/865801/show Affected files: user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java

[gwt-contrib] UiBinder. Design time tweaks for @UiField and @UiHandler (issue834802)

2010-09-07 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: It turns out that previous patch was not enough. In new one instead of preventing failing when no owner or field found, we disable assigning to fields and support for event handlers at all. However we can not disable them globally, for all UiBinder templates, we

[gwt-contrib] Re: UiBinder. Design time tweaks for @UiField (issue792801)

2010-08-30 Thread Konstantin . Scheglov
I don't see this patch in SVN yet. Was it committed? http://gwt-code-reviews.appspot.com/792801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] UiBinder. Design time tweaks for @UiField (issue792801)

2010-08-23 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: This patch contains changes required for reliable editing of ui:field attribute in template and corresponding @UiField in Java. Solved problems: 1. When GWT Designer calls createAndBindUi(), it can not provide owner, because we can not instantiate it, and it is

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

2010-08-19 Thread Konstantin . Scheglov
These caches contain types which have a circular reference pattern with the TypeOracle. If we make a hard reference to the cache here, we end up pinning the TypeOracle. You could break hard reference on TypeOracle for example by using weak reference on method from

[gwt-contrib] Allow to keep size of Widget on DeckPanel (issue732802)

2010-08-07 Thread Konstantin . Scheglov
Reviewers: jgw, Ray Ryan, Description: I probably already told about this couple years ago, but DeckPanel, as it is done now, is IMHO not reliable in area of size management. More precise - using DeckPanel in TabPanel. TabPanel uses VerticalPanel to host TabBar and DeckPanel, and it set

[gwt-contrib] Tests and tweaks for DisclosurePanel and StackLayoutPanel parsers (issue736801)

2010-08-03 Thread Konstantin . Scheglov
Reviewers: Ray Ryan, Description: 1. Problems in assertFirstHeader(). 1.1. invalid condition; 1.2. invalid reference on second argument. 2. Use addStatement() instead of addInitStatement(), because same is done everywhere. 3. Small tweaks. 4. Set of tests, including all bad cases. Please review

[gwt-contrib] Support for custom MenuItem, MenuItemSeparator and MenuBar. (issue702803)

2010-08-01 Thread Konstantin . Scheglov
Reviewers: Ray Ryan, Description: See http://code.google.com/p/google-web-toolkit/issues/detail?id=4550 Please review this at http://gwt-code-reviews.appspot.com/702803/show Affected files: user/src/com/google/gwt/uibinder/elementparsers/MenuBarParser.java

[gwt-contrib] UiBinder. Parser for AbsolutePanel. (issue715802)

2010-07-27 Thread Konstantin . Scheglov
Reviewers: Ray Ryan, Please review this at http://gwt-code-reviews.appspot.com/715802/show Affected files: user/src/com/google/gwt/uibinder/elementparsers/AbsolutePanelParser.java user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java

[gwt-contrib] Re: UiBinder. Parser for AbsolutePanel. (issue715802)

2010-07-27 Thread Konstantin . Scheglov
1. Should I remove groups only from this AbsolutePanelParser test or from DesignTimeUtilsTest too? 2. I agree to use sorting methods with tests, however as with formatting I have one problem. I would like to do this automatically, i.e. just configure this in Save Actions. And this means that

[gwt-contrib] Re: UiBinder tweaks for GWT Designer (issue693801)

2010-07-21 Thread Konstantin Scheglov
in XMLElement http://gwt-code-reviews.appspot.com/693801/show -- Konstantin Scheglov, Instantiations, Inc. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UiBinder tweaks for GWT Designer (issue693801)

2010-07-15 Thread Konstantin Scheglov
-- Konstantin Scheglov, Instantiations, Inc. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] UiBinder tweaks for GWT Designer (issue693801)

2010-07-14 Thread Konstantin . Scheglov
Reviewers: Ray Ryan, Description: It uses just designTime and dt names, nothing specific for GWT Designer. Please review this at http://gwt-code-reviews.appspot.com/693801/show Affected files: user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java

Re: [gwt-contrib] UiBinder tweaks for GWT Designer

2010-07-02 Thread Konstantin Scheglov
. But I think that we should weight what is better/worse - quick check for design time or more-less time consuming calculation of check sum, plus having not-so-friendly class names in hosted mode. -- Konstantin Scheglov, Instantiations, Inc. -- http://groups.google.com/group/Google-Web-Toolkit

Re: [gwt-contrib] UiBinder tweaks for GWT Designer

2010-07-01 Thread Konstantin Scheglov
as it is now. -- Konstantin Scheglov, Instantiations, Inc. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] UiBinder. Parser for TextAlignConstant (issue612803)

2010-06-22 Thread Konstantin . Scheglov
Reviewers: jgw, Description: It uses friendly names. I will post patch with adding support for names like this for horizontal/vertical alignments (in addition, not replace to keep compatibility with existing code) later. Please review this at http://gwt-code-reviews.appspot.com/612803/show

[gwt-contrib] UiBinder. Add tests for horizontal/vertical alignment parsers. (issue633801)

2010-06-17 Thread Konstantin . Scheglov
Reviewers: , Description: I would like to start contributing small changes into UiBinder, mostly to make it better for GWT Designer. For beginning I want to contribute two tests. BTW, why these parsers use so unfriendly names for alignments? ALIGN_RIGHT looks not very good in XML. Why not just