[gwt-contrib] [google-web-toolkit] r9726 committed - CollectorNull should not set stack traces when stack stripping is enab...

[codesite-noreply]

Revision: 9726
Author: cromwell...@google.com
Date: Thu Feb 10 14:05:42 2011
Log: CollectorNull should not set stack traces when stack stripping is  
enabled. Throwable.getStackTrace() already handles the case of a null stack  
trace and constructs an empty array.

Review at http://gwt-code-reviews.appspot.com/1355801

http://code.google.com/p/google-web-toolkit/source/detail?r=9726

Modified:
 /trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java

=======================================
--- /trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java	 
Fri Feb  4 08:47:41 2011
+++ /trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java	 
Thu Feb 10 14:05:42 2011
@@ -384,12 +384,12 @@

     @Override
     public void createStackTrace(JavaScriptException e) {
-      e.setStackTrace(new StackTraceElement[0]);
+      // empty, since Throwable.getStackTrace() properly handles null
     }

     @Override
     public void fillInStackTrace(Throwable t) {
-      t.setStackTrace(new StackTraceElement[0]);
+      // empty, since Throwable.getStackTrace() properly handles null
     }
   }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors