http://gwt-code-reviews.appspot.com/770801/diff/1/5
File
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java
(right):

http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode32
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:32:
private static final CssResourceObserver IMPL =
GWT.create(CssResourceObserver.class);
This way there's effectively only one observer instance allowed?
I think Observer implies 1-N.

http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode68
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:68:
private native JavaScriptObject ensureMap() /*-{
Do we have to use JSNI?

http://gwt-code-reviews.appspot.com/770801/diff/1/6
File user/src/com/google/gwt/resources/css/ClassRenamer.java (right):

http://gwt-code-reviews.appspot.com/770801/diff/1/6#newcode138
user/src/com/google/gwt/resources/css/ClassRenamer.java:138:
sheet.getDebugInfo().addToClassMap(sourceClassName, sourceClassName);
JavaDoc says getDebugInfo could return null ...
Oh, I mixed it with CssResource.DebugInfo. So, the names are confusing
...
CssDebugInfo contains (almost) only setters. Is it a builder for
CssResource.DebugInfo?

http://gwt-code-reviews.appspot.com/770801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to