[gwt-contrib] Adding RTL support to the images used in CellTree. Removing automatic keyboard focus from the co... (issue836801)

[jlabanca]

Reviewers: rice,

Description:
Adding RTL support to the images used in CellTree. Removing automatic
keyboard focus from the constructor because it can result in an
IndexOutOfBoundsEception if the tree nodes are loaded asynchronously.

Please review this at http://gwt-code-reviews.appspot.com/836801/show

Affected files:
  M user/src/com/google/gwt/user/cellview/client/CellTree.java


Index: user/src/com/google/gwt/user/cellview/client/CellTree.java
===================================================================
--- user/src/com/google/gwt/user/cellview/client/CellTree.java	(revision  
8705)
+++ user/src/com/google/gwt/user/cellview/client/CellTree.java	(working  
copy)
@@ -53,12 +53,15 @@
    */
   public static interface CleanResources extends Resources {

+    @ImageOptions(flipRtl = true)
     @Source("cellTreeClosedArrow.png")
     ImageResource cellTreeClosedItem();

+    @ImageOptions(flipRtl = true)
     @Source("cellTreeLoadingClean.gif")
     ImageResource cellTreeLoading();

+    @ImageOptions(flipRtl = true)
     @Source("cellTreeOpenArrow.png")
     ImageResource cellTreeOpenItem();

@@ -118,22 +121,25 @@
     /**
      * An image indicating a closed branch.
      */
+    @ImageOptions(flipRtl = true)
     ImageResource cellTreeClosedItem();

     /**
      * An image indicating that a node is loading.
      */
+    @ImageOptions(flipRtl = true)
     ImageResource cellTreeLoading();

     /**
      * An image indicating an open branch.
      */
+    @ImageOptions(flipRtl = true)
     ImageResource cellTreeOpenItem();

     /**
      * The background used for selected items.
      */
-    @ImageOptions(repeatStyle = RepeatStyle.Horizontal)
+    @ImageOptions(repeatStyle = RepeatStyle.Horizontal, flipRtl = true)
     ImageResource cellTreeSelectedBackground();

     /**
@@ -521,7 +527,6 @@
         this, null, null, getElement(), rootValue);
     keyboardSelectedNode = rootNode = root;
     root.setOpen(true, false);
-    keyboardSelectedNode.keyboardEnter(0, false);
   }

   /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors