Re: [gwt-contrib] Facilitate implementations of EventBus in other packages (issue1443804)

2011-05-20 Thread Ray Ryan
Looks good to me. Do you still need the patch that brings back GwtEvent.setSource, or is this enough by itself? On Thu, May 19, 2011 at 3:58 PM, stephen.haber...@gmail.com wrote: Reviewers: rjrjr, Description: Adds two protected static methods to EventBus that expose otherwise inaccessible

Re: [gwt-contrib] Facilitate implementations of EventBus in other packages (issue1443804)

2011-05-20 Thread Stephen Haberman
Do you still need the patch that brings back GwtEvent.setSource, or is this enough by itself? If I had any sort of external userbase (which I don't), putting GwtEvent setSource back would be preferrable as then users' code could keep using an existing release of my project while they upgraded

[gwt-contrib] Facilitate implementations of EventBus in other packages (issue1443804)

2011-05-19 Thread stephen . haberman
Reviewers: rjrjr, Description: Adds two protected static methods to EventBus that expose otherwise inaccessible methods on Event (setSource and dispatch) to subclasses of EventBus. This is not a huge deal to me, but, in general, it would be nice to move my EventBus implementation out of a c.g